Add specs for result and webhook behaviors

Author: vipulnsward

spec/uploadcare/error_handler_spec.rb

@@ -186,6 +186,32 @@ module Uploadcare
           handler.send(:catch_upload_errors, response)
         end.not_to raise_error
       end
+
+      it 'handles invalid JSON body' do
+        response = { status: 200, body: 'invalid-json' }
+
+        expect do
+          handler.send(:catch_upload_errors, response)
+        end.not_to raise_error
+      end
+    end
+
+    describe '#raise_throttle_error' do
+      it 'raises ThrottleError with retry-after' do
+        response = { status: 429, headers: { 'Retry-After' => '2.5' } }
+
+        expect do
+          handler.send(:raise_throttle_error, response, 'Too many requests')
+        end.to raise_error(Uploadcare::Exception::ThrottleError) { |error| expect(error.timeout).to eq(2.5) }
+      end
+
+      it 'defaults to 10 seconds when retry-after is missing' do
+        response = { status: 429, headers: {} }
+
+        expect do
+          handler.send(:raise_throttle_error, response, 'Too many requests')
+        end.to raise_error(Uploadcare::Exception::ThrottleError) { |error| expect(error.timeout).to eq(10.0) }
+      end
     end
   end
 end

spec/uploadcare/param/upload/upload_params_generator_spec.rb

@@ -33,6 +33,13 @@
     expect(params['UPLOADCARE_STORE']).to eq('0')
   end
 
+  it 'passes through store values' do
+    config = Uploadcare::Configuration.new(public_key: 'pub')
+    params = described_class.call(options: { store: 'auto' }, config: config)
+
+    expect(params['UPLOADCARE_STORE']).to eq('auto')
+  end
+
   it 'uses explicit signature params when provided' do
     config = Uploadcare::Configuration.new(public_key: 'pub', sign_uploads: true)
     params = described_class.call(options: { signature: 'sig', expire: 123 }, config: config)
@@ -41,6 +48,16 @@
     expect(params['expire']).to eq(123)
   end
 
+  it 'supports non-hash signature data' do
+    config = Uploadcare::Configuration.new(public_key: 'pub', sign_uploads: true)
+    allow(Uploadcare::Param::Upload::SignatureGenerator).to receive(:call).and_return('signature-string')
+
+    params = described_class.call(options: {}, config: config)
+
+    expect(params['signature']).to eq('signature-string')
+    expect(params['expire']).to be_nil
+  end
+
   it 'converts metadata values to strings' do
     config = Uploadcare::Configuration.new(public_key: 'pub')
     params = described_class.call(options: { metadata: { count: 12 } }, config: config)

spec/uploadcare/resources/paginated_collection_spec.rb

@@ -145,6 +145,17 @@ module Uploadcare
       end
     end
 
+    describe '#all' do
+      it 'collects resources across pages' do
+        next_collection = described_class.new(params.merge(resources: [double('Resource3')], next_page: nil))
+        allow(subject).to receive(:next_page).and_return(next_collection, nil)
+
+        items = subject.all
+
+        expect(items.length).to eq(3)
+      end
+    end
+
     describe '#fetch_page' do
       let(:page_url) { 'https://api.uploadcare.com/files/?page=2&limit=50' }
       let(:page_response) do

spec/uploadcare/resources/webhook_spec.rb

@@ -129,6 +129,16 @@
       expect(webhook).to be_a(described_class)
       expect(webhook.target_url).to eq(target_url)
     end
+
+    it 'allows deactivating a webhook' do
+      allow_any_instance_of(Uploadcare::WebhookClient).to receive(:update_webhook)
+        .with(id: webhook_id, options: hash_including(is_active: false), request_options: {})
+        .and_return(response_body.merge('is_active' => false))
+
+      webhook = described_class.update(id: webhook_id, is_active: false)
+
+      expect(webhook.is_active).to eq(false)
+    end
   end
   describe '.delete' do
     let(:target_url) { 'https://example.com/hooks' }

spec/uploadcare/result_spec.rb

@@ -49,4 +49,11 @@
 
     expect { result.value! }.to raise_error(StandardError, 'nope')
   end
+
+  it 'raises inspected value for non-exception errors' do
+    error = { error: 'boom' }
+    result = described_class.failure(error)
+
+    expect { result.value! }.to raise_error(RuntimeError, /\{error: "boom"\}/)
+  end
 end

spec/uploadcare/webhook_signature_verifier_spec.rb

@@ -94,6 +94,23 @@ module Uploadcare
           expect(signature_valid?).to be_falsey
         end
       end
+
+      context 'when webhook body is missing' do
+        let(:params) { super().merge(webhook_body: nil) }
+
+        it 'returns false' do
+          expect(signature_valid?).to be_falsey
+        end
+      end
+    end
+
+    describe '.secure_compare?' do
+      it 'falls back to byte comparison when OpenSSL helper is missing' do
+        allow(OpenSSL).to receive(:fixed_length_secure_compare).and_raise(NoMethodError)
+
+        expect(described_class.secure_compare?('abc', 'abc')).to be(true)
+        expect(described_class.secure_compare?('abc', 'abd')).to be(false)
+      end
     end
   end
 end