You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Non-blocking follow-ups identified while reviewing #218 (PETSc-native XDMF viz topology, merged bc834b4):
write_checkpoint()FutureWarning fires from UW3's own snapshot subsystem.src/underworld3/checkpoint/disk_snapshot.py:314 calls mesh.write_checkpoint(...), which Use PETSc-native XDMF visualization topology #218 deprecated. Harmless today (setup.cfgfilterwarnings has no error escalation) but self-inflicted warning spam. Fix: have the snapshot backend call _write_petsc_reload_file / write_timestep(..., petsc_reload=True) directly, or suppress the warning for internal callers.
Dead/fragile attr read in checkpoint_xdmf: topo["cells"].attrs["cell_dim"] is read but never used (topology type is derived from numCorners+spaceDim). Delete it — it's a needless dependency on a PETSc-internal attr name that could KeyError on a future PETSc/cell type.
Unify XDMF attribute writers: Use PETSc-native XDMF visualization topology #218 flattened the meshVar attribute DataItem (removed HyperSlab) but the parallel swarmVar block still uses ItemType="HyperSlab". Not a regression; unify for consistency.
Non-blocking follow-ups identified while reviewing #218 (PETSc-native XDMF viz topology, merged bc834b4):
write_checkpoint()FutureWarningfires from UW3's own snapshot subsystem.src/underworld3/checkpoint/disk_snapshot.py:314callsmesh.write_checkpoint(...), which Use PETSc-native XDMF visualization topology #218 deprecated. Harmless today (setup.cfgfilterwarningshas noerrorescalation) but self-inflicted warning spam. Fix: have the snapshot backend call_write_petsc_reload_file/write_timestep(..., petsc_reload=True)directly, or suppress the warning for internal callers.Dead/fragile attr read in
checkpoint_xdmf:topo["cells"].attrs["cell_dim"]is read but never used (topology type is derived fromnumCorners+spaceDim). Delete it — it's a needless dependency on a PETSc-internal attr name that couldKeyErroron a future PETSc/cell type.Unify XDMF attribute writers: Use PETSc-native XDMF visualization topology #218 flattened the meshVar attribute DataItem (removed HyperSlab) but the parallel swarmVar block still uses
ItemType="HyperSlab". Not a regression; unify for consistency.cc @gthyagi
Underworld development team with AI support from Claude Code