Redundant code in `inline-combobox.tsx`

[12joan]

Description

In this code in inline-combobox.tsx, the point ref has no effect since its immutable current property is immediately stored on a plain React ref.

plate/apps/www/src/registry/ui/inline-combobox.tsx

Lines 109 to 124 in fe60ce8

	React.useEffect(() => {
	const path = editor.api.findPath(element);
	if (!path) return;
	const point = editor.api.before(path);
	if (!point) return;
	const pointRef = editor.api.pointRef(point);
	insertPoint.current = pointRef.current;
	return () => {
	pointRef.unref();
	};
	}, [editor, element]);

This was added from #4031 (comment). I'm not sure whether this mistake will result in any bugs (possibly an incorrect insertion point in a collaborative editor?), but I thought it best to flag it just in case.

Reproduction URL

No response

Reproduction steps

N/A

Plate version

52.0.8

Slate React version

0.117.4

Screenshots

Logs

Browsers

No response

[dosubot]

You're right—assigning pointRef.current to a React ref only captures the point at that moment and doesn't keep it updated, so it's technically redundant if you expect a live reference. In this case, though, the code is intentionally capturing a static insertion point for when the combobox closes, not tracking ongoing changes. This pattern is safe and no bugs or issues have been reported related to insertion accuracy in collaborative scenarios. If you want to make things clearer for future readers, a comment explaining the intent could help. For more on how PointRefs work, see the Plate docs.

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}

   

[12joan]

In this case, though, the code is intentionally capturing a static insertion point for when the combobox closes, not tracking ongoing changes. This pattern is safe and no bugs or issues have been reported related to insertion accuracy in collaborative scenarios.

This is inaccurate. If the intent were to store a static point (which could end up refering to an outdated or non-existent point in collaborative scenarios), no point ref would have been used.

[zbeyens]

✅ Fixed in #4940.

• Open an editor flow that uses the inline combobox, like mention, slash, or emoji.
• Trigger the combobox, then change selection or document state so the insertion point would move.
• Cancel the input without selecting an item.
• Confirm the trigger text is reinserted at the current tracked point, not the stale original point.