Skip to content

Commit d9438b0

Browse files
authored
Merge pull request #1 from sookim-1/fix/ios-repo-path-adjustments
Fix paths, update versions, and adjust documentation for RIBs-iOS repo
2 parents 46eb7b9 + 68e1661 commit d9438b0

17 files changed

Lines changed: 64 additions & 51 deletions

File tree

Cartfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
github "ReactiveX/RxSwift" ~> 6.0.0
1+
github "ReactiveX/RxSwift" ~> 6.5.0

Package.resolved

Lines changed: 16 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Package.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,18 @@ let package = Package(
1010
.library(name: "RIBs", targets: ["RIBs"]),
1111
],
1212
dependencies: [
13-
.package(url: "https://github.com/ReactiveX/RxSwift", from: "6.0.0"),
13+
.package(url: "https://github.com/ReactiveX/RxSwift", from: "6.5.0"),
1414
],
1515
targets: [
1616
.target(
1717
name: "RIBs",
1818
dependencies: ["RxSwift", "RxRelay"],
19-
path: "ios/RIBs"
19+
path: "RIBs"
2020
),
2121
.testTarget(
2222
name: "RIBsTests",
2323
dependencies: ["RIBs"],
24-
path: "ios/RIBsTests"
24+
path: "RIBsTests"
2525
),
2626
]
2727
)

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
[![Cocoapods Compatible](https://img.shields.io/cocoapods/v/RIBs.svg)](https://cocoapods.org/pods/ribs)
77
[![Carthage Compatible](https://img.shields.io/badge/Carthage-compatible-4BC51D.svg)](https://github.com/Carthage/Carthage)
88

9+
> ⚠️ **Alert:** RIBs for Android [separate repo](https://github.com/uber/ribs)
10+
911
RIBs is the cross-platform architecture framework behind many mobile apps at Uber. The name RIBs is short for Router, Interactor and Builder, which are core components of this architecture. This framework is designed for mobile apps with a large number of engineers and nested states.
1012

1113
The RIBs architecture provides:

RELEASING.md

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,3 @@
1-
Releasing
2-
=========
3-
4-
Android
5-
-------
6-
7-
1. Change the version in `gradle.properties` to a non-SNAPSHOT version.
8-
2. Update the `README.md` with the new version.
9-
3. Update the `CHANGELOG.md` for the impending release.
10-
4. `git commit -am "Prepare for release X.Y.Z."` (where X.Y.Z is the new version)
11-
5. `git tag -a X.Y.Z -m "Version X.Y.Z"` (where X.Y.Z is the new version)
12-
6. `./gradlew clean publish --no-daemon --no-parallel && ./gradlew closeAndReleaseRepository`
13-
7. Update the `gradle.properties` to the next SNAPSHOT version.
14-
8. `git commit -am "Prepare next development version."`
15-
9. `git push && git push --tags`
16-
171
iOS
182
---
193

RIBs.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ RIBs is the cross-platform architecture behind many mobile apps at Uber. This ar
1010
s.author = { 'uber' => 'mobile-open-source@uber.com' }
1111
s.source = { :git => 'https://github.com/uber/RIBs.git', :tag => 'v' + s.version.to_s }
1212
s.ios.deployment_target = '9.0'
13-
s.source_files = 'ios/RIBs/Classes/**/*'
13+
s.source_files = 'RIBs/Classes/**/*'
1414
s.dependency 'RxSwift', '~> 6.5.0'
1515
s.dependency 'RxRelay', '~> 6.5.0'
1616
end

test.md

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,3 @@
1-
Releasing
2-
=========
3-
4-
Android
5-
-------
6-
7-
1. Change the version in `gradle.properties` to a non-SNAPSHOT version.
8-
2. Update the `CHANGELOG.md` for the impending release.
9-
3. Update the `README.md` with the new version.
10-
4. `git commit -am "Prepare for release X.Y.Z."` (where X.Y.Z is the new version)
11-
5. `git tag -a X.Y.Z -m "Version X.Y.Z"` (where X.Y.Z is the new version)
12-
6. `./gradlew clean uploadArchives`
13-
7. Update the `gradle.properties` to the next SNAPSHOT version.
14-
8. `git commit -am "Prepare next development version."`
15-
9. `git push && git push --tags`
16-
10. Visit [Sonatype Nexus](https://oss.sonatype.org/) and promote the artifact.
17-
181
iOS
192
---
203

tutorials/tutorial1/Podfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ target 'TicTacToe' do
77
inhibit_all_warnings!
88

99
# Pods for TicTacToe
10-
pod 'RIBs', :path => '../../../'
10+
pod 'RIBs', :path => '../../'
1111
pod 'SnapKit', '~> 4.0.0'
1212
pod 'RxCocoa', '~> 6.5'
1313

14-
end
14+
end

tutorials/tutorial1/README.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,10 @@ pod install
1919
```
2020

2121
Then, open the TicTacToe.xcworkspace that was generated by `pod install` and follow the steps described in [tutorial 1](https://github.com/uber/RIBs/wiki/iOS-Tutorial-1) on the RIBs wiki.
22+
23+
**Warning**: If you encounter the following error during build execution:
24+
25+
`SnapKit Pod SDK does not contain 'libarclite' at the path '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/arc/libarclite_iphoneos.a'; try increasing the minimum deployment target`
26+
27+
-> Please change the Minimum Deployment Target for SnapKit in the Pods project to **9.0** under TARGETS.
28+

tutorials/tutorial2/Podfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ use_frameworks!
44
inhibit_all_warnings!
55

66
target 'TicTacToe' do
7-
pod 'RIBs', :path => '../../../'
7+
pod 'RIBs', :path => '../../'
88
pod 'SnapKit', '~> 4.0.0'
9-
pod 'RxCocoa', '~> 5.1'
9+
pod 'RxCocoa', '~> 6.5'
1010
end
1111

1212
target 'TicTacToeTests' do
13-
pod 'RIBs', :path => '../../../'
13+
pod 'RIBs', :path => '../../'
1414
end

0 commit comments

Comments
 (0)