Merge pull request #233 from SpencerMalone/throw-on-json-encoding

Throw exception if we fail to json encode predefined error responses to appease phpstan

Author: sagikazarmark

lib/src/Router.php

@@ -81,7 +81,7 @@ private function writeNoRouteError(ServerRequestInterface $request): ResponseInt
             'meta' => [
                 'twirp_invalid_route' => $request->getMethod().' '.$request->getUri()->getPath(),
             ],
-        ]));
+        ], \JSON_THROW_ON_ERROR));
 
         return $this->responseFactory
             ->createResponse($statusCode)

lib/src/Server.php

@@ -78,7 +78,7 @@ private function writeNoRouteError(ServerRequestInterface $request): ResponseInt
             'meta' => [
                 'twirp_invalid_route' => $request->getMethod().' '.$request->getUri()->getPath(),
             ],
-        ]));
+        ], \JSON_THROW_ON_ERROR));
 
         return $this->responseFactory
             ->createResponse($statusCode)

phpstan-baseline.neon

@@ -258,18 +258,6 @@ parameters:
 			count: 1
 			path: lib/src/Context.php
 
-		-
-			message: '#^Parameter \#1 \$content of method Psr\\Http\\Message\\StreamFactoryInterface\:\:createStream\(\) expects string, string\|false given\.$#'
-			identifier: argument.type
-			count: 1
-			path: lib/src/Router.php
-
-		-
-			message: '#^Parameter \#1 \$content of method Psr\\Http\\Message\\StreamFactoryInterface\:\:createStream\(\) expects string, string\|false given\.$#'
-			identifier: argument.type
-			count: 1
-			path: lib/src/Server.php
-
 		-
 			message: '#^Method Twirp\\ServerHooks\:\:error\(\) has parameter \$ctx with no value type specified in iterable type array\.$#'
 			identifier: missingType.iterableValue