From a364245ca5d70b5354ef5118bac6a26f893d601f Mon Sep 17 00:00:00 2001 From: lovely90133 Date: Sun, 3 May 2026 23:38:59 +0800 Subject: [PATCH] =?UTF-8?q?fix:=20=E4=BF=AE=E5=A4=8D=E7=BB=84=E4=BB=B6?= =?UTF-8?q?=E4=BE=9D=E8=B5=96=E5=92=8C=E5=8F=98=E9=87=8F=E5=A3=B0=E6=98=8E?= =?UTF-8?q?=E9=97=AE=E9=A2=98?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 修复多个组件中缺少的依赖项，将params.groupId添加到useEffect依赖数组 修正group.js中未声明的变量，使用let声明expensePerPerson和循环变量val 编辑费用后重定向到配置的VIEW_GROUP_URL --- .DS_Store | Bin 10244 -> 10244 bytes client/src/components/expense/editExpense.jsx | 4 ++-- .../components/groups/settlement/index.jsx | 2 +- .../groups/viewGroup/groupCategoryGraph.jsx | 4 ++-- .../groups/viewGroup/groupMonthlyGraph.jsx | 6 +++--- .../src/components/groups/viewGroup/index.jsx | 2 +- components/group.js | 8 ++++---- 7 files changed, 13 insertions(+), 13 deletions(-) diff --git a/.DS_Store b/.DS_Store index eced0a80d094d887f18dff52d1e85a625dee8412..aa53cfce7bd3dc9fd75190a8ef21278523fa4579 100644 GIT binary patch delta 57 zcmZn(XbG6$mJU^hRb`eq)1+02{&iIg*LzAB!>xS3I!jdf!|Im>2th2JcbBgJH3 H!c~j_KAaOA delta 810 zcmZn(XbG6$&uFzVU^hRb)n*=n+024W3@!{#N#(@_NjdpR3=9n0CNB^uoHw;eB&n*B6h|gj!gNf(nySPA& z<+$uCpyF}jm?J_i1*cp=2Esg+I}d3**UqMUCs>%8;GMAYl0hXdGM)*@-fbGPH9Hj)0tqB#&?= zHhE;HG6)2KoC?*;#8AAMU$mN0l7}G==-d>BREBtlTrjH?=z&zQ^Bb9r4JS_*a;e9u z2-)#WMOXg=Ex@T3*)#mctozx_z@EXQ9_G0q1`c90Ap4e;c>~C|I1S%iEhfsknO)&G R%jVU>#X~68Ci9Eh0RY4Jye|L% diff --git a/client/src/components/expense/editExpense.jsx b/client/src/components/expense/editExpense.jsx index acc39a2..2ab8da9 100644 --- a/client/src/components/expense/editExpense.jsx +++ b/client/src/components/expense/editExpense.jsx @@ -16,7 +16,7 @@ import Loading from '../loading'; import { useNavigate } from "react-router-dom"; import AlertBanner from '../AlertBanner'; import { parseISO } from 'date-fns'; - +import configData from '../../config.json'; export default function EditExpense() { @@ -55,7 +55,7 @@ export default function EditExpense() { onSubmit: async () => { setLoading(true) if(await editExpenseService(values, setAlert, setAlertMessage)) - navigate(-1) + window.location = configData.VIEW_GROUP_URL + values.groupId }, }); diff --git a/client/src/components/groups/settlement/index.jsx b/client/src/components/groups/settlement/index.jsx index cfd0316..16aca79 100644 --- a/client/src/components/groups/settlement/index.jsx +++ b/client/src/components/groups/settlement/index.jsx @@ -35,7 +35,7 @@ export const GroupSettlements = ({ currencyType }) => { setLoading(false) } getGroupSettlement() - }, [reload]) + }, [reload, params.groupId]) return ( <> diff --git a/client/src/components/groups/viewGroup/groupCategoryGraph.jsx b/client/src/components/groups/viewGroup/groupCategoryGraph.jsx index c4f9c19..f048ba6 100644 --- a/client/src/components/groups/viewGroup/groupCategoryGraph.jsx +++ b/client/src/components/groups/viewGroup/groupCategoryGraph.jsx @@ -66,12 +66,12 @@ const GroupCategoryGraph = ({currencyType}) => { } const category_exp = await getGroupCategoryExpService(groupIdJson, setAlert, setAlertMessage) - setCategoryExp(category_exp.data.data) + setCategoryExp(category_exp?.data?.data) setLoading(false) } getGroupCategoryExpense() - }, []) + }, [params.groupId]) return ( <> {loading ? : diff --git a/client/src/components/groups/viewGroup/groupMonthlyGraph.jsx b/client/src/components/groups/viewGroup/groupMonthlyGraph.jsx index 2e91c3a..36b5cc9 100644 --- a/client/src/components/groups/viewGroup/groupMonthlyGraph.jsx +++ b/client/src/components/groups/viewGroup/groupMonthlyGraph.jsx @@ -71,13 +71,13 @@ const GroupMonthlyGraph = () => { const monthly_exp = await getGroupMonthlyExpService(groupIdJson, setAlert, setAlertMessage) const daily_exp = await getGroupDailyExpService(groupIdJson, setAlert, setAlertMessage) - setMonthlyExp(monthly_exp.data.data) - setDailyExp(daily_exp.data.data) + setMonthlyExp(monthly_exp?.data?.data) + setDailyExp(daily_exp?.data?.data) setLoading(false) } getGroupMonthlyExpense() - }, []) + }, [params.groupId]) return ( <> {loading ? : diff --git a/client/src/components/groups/viewGroup/index.jsx b/client/src/components/groups/viewGroup/index.jsx index 8e64b32..8e4ff54 100644 --- a/client/src/components/groups/viewGroup/index.jsx +++ b/client/src/components/groups/viewGroup/index.jsx @@ -80,7 +80,7 @@ export default function ViewGroup() { setLoading(false) } getGroupDetails() - }, []); + }, [params.groupId]); const CategoryStyle = styled('span')(({ theme }) => ({ top: 22, diff --git a/components/group.js b/components/group.js index ae54a9f..7c860fd 100644 --- a/components/group.js +++ b/components/group.js @@ -301,7 +301,7 @@ exports.addSplit = async (groupId, expenseAmount, expenseOwner, expenseMembers) }) group.groupTotal += expenseAmount group.split[0][expenseOwner] += expenseAmount - expensePerPerson = expenseAmount / expenseMembers.length + let expensePerPerson = expenseAmount / expenseMembers.length expensePerPerson = Math.round((expensePerPerson + Number.EPSILON) * 100) / 100; //Updating the split values per user for (var user of expenseMembers) { @@ -310,7 +310,7 @@ exports.addSplit = async (groupId, expenseAmount, expenseOwner, expenseMembers) //Nullifying split - check if the group balance is zero else added the diff to owner let bal=0 - for(val of Object.entries(group.split[0])) + for(let val of Object.entries(group.split[0])) { bal += val[1] } @@ -334,7 +334,7 @@ exports.clearSplit = async (groupId, expenseAmount, expenseOwner, expenseMembers }) group.groupTotal -= expenseAmount group.split[0][expenseOwner] -= expenseAmount - expensePerPerson = expenseAmount / expenseMembers.length + let expensePerPerson = expenseAmount / expenseMembers.length expensePerPerson = Math.round((expensePerPerson + Number.EPSILON) * 100) / 100; //Updating the split values per user for (var user of expenseMembers) { @@ -343,7 +343,7 @@ exports.clearSplit = async (groupId, expenseAmount, expenseOwner, expenseMembers //Nullifying split - check if the group balance is zero else added the diff to owner let bal=0 - for(val of Object.entries(group.split[0])) + for(let val of Object.entries(group.split[0])) { bal += val[1] }