Commit fd7e01d
fix(webapp): mollifier buffered-path auth checks + drop high-cardinality envId from realtime counter
Three CodeRabbit findings from #3709, re-raised on #3757:
- resources.taskruns.$runParam.debug.ts: buffered fallback returned the
run's queue / concurrencyKey / queueTimestamp from the snapshot
without verifying org membership. Any authenticated user who knew a
friendlyId could read those fields across orgs. Now joins through
orgMember the same way the PG path does and 404s on miss.
- resources.runs.$runParam.logs.download.ts: same shape — the buffered
placeholder leaked runId existence to non-members on direct URL
access. Same orgMember check now gates the buffered branch.
- mollifierTelemetry.server.ts: recordRealtimeBufferedSubscription was
attaching envId (a UUID) as an OTEL counter dimension, violating the
project's "no high-cardinality IDs in metric attributes" guideline.
Dropped the parameter; the call site's logger.info still emits envId.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 07ce6ed commit fd7e01d
4 files changed
Lines changed: 24 additions & 8 deletions
File tree
- apps/webapp/app
- routes
- v3/mollifier
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | | - | |
| 82 | + | |
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
| |||
Lines changed: 10 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
40 | 39 | | |
41 | 40 | | |
42 | 41 | | |
43 | 42 | | |
44 | 43 | | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
45 | 51 | | |
46 | 52 | | |
47 | 53 | | |
| |||
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
57 | 67 | | |
58 | 68 | | |
59 | 69 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
35 | | - | |
36 | | - | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
0 commit comments