Skip to content

Commit f126737

Browse files
d-csclaude
andcommitted
style(webapp): trigger review follow-ups — F4 comment, span-body indent, docs URL
idempotencyKeys.server.ts: reword 'bypasses the gate via F4' to 'bypasses the gate entirely' — last residual internal planning-label reference I missed in the earlier cleanup pass. triggerTask.server.ts: reindent the startSpan arrow-function body to conventional depth (+4 sp on lines 143-619). The body was under-indented relative to the 'async (span) => {' opener after the try-wrapper for claim resolution was added around it; closes (arrow at 8sp, startSpan at 6sp) were already conventional, so only the body needed shifting. Pure whitespace — diff stat is balanced 413/413. mollifierMollify.server.ts: docs URL → https://trigger.dev/docs/management/tasks/batch-trigger. The previous burst-handling anchor doesn't exist on the docs site. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 9de966d commit f126737

3 files changed

Lines changed: 413 additions & 413 deletions

File tree

apps/webapp/app/runEngine/concerns/idempotencyKeys.server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ export class IdempotencyKeyConcern {
225225
// Pre-gate claim — closes the PG+buffer race during gate transition.
226226
// All same-key triggers serialise here before evaluateGate decides
227227
// PG-pass-through vs mollify. Skipped for triggerAndWait
228-
// (resumeParentOnCompletion) — that path bypasses the gate via F4
228+
// (resumeParentOnCompletion) — that path bypasses the gate entirely
229229
// and its existing PG-side dedup is sufficient.
230230
if (!request.body.options?.resumeParentOnCompletion) {
231231
const ttlSeconds = Math.max(

0 commit comments

Comments
 (0)