fix(run-store): drop force-injected id from findRunsByIds results when unrequested

findRunsByIds forces `id` into the select so it can key the result map, but did
not remove it afterwards, so returned rows carried an `id` the declared payload
type did not include. Delete the injected id from each value when the caller's
select did not request it; the map stays keyed by id.

Author: d-cs

internal-packages/run-store/src/PostgresRunStore.findRunsByIds.test.ts

@@ -162,6 +162,11 @@ describe("PostgresRunStore.findRunsByIds", () => {
       expect(byId.get(runId2)?.friendlyId).toBe("run_findbyids_2_friendly");
       expect(byId.get(runId2)?.status).toBe("PENDING");
 
+      // The select omitted `id`; the id we force-inject for keying must not leak into the value
+      // (it would otherwise violate the declared payload type and expose an unrequested id).
+      expect("id" in (byId.get(runId1) as object)).toBe(false);
+      expect("id" in (byId.get(runId2) as object)).toBe(false);
+
       // GROUPED: one findMany for the WHOLE batch, never one findFirst per id.
       expect(counting.counts.taskRun.findMany).toBe(1);
       expect(counting.counts.taskRun.findFirst).toBe(0);

internal-packages/run-store/src/PostgresRunStore.ts

@@ -1540,8 +1540,15 @@ export class PostgresRunStore implements RunStore {
       client
     )) as Record<string, unknown>[];
     const byId = new Map<string, unknown>();
+    // Strip the id we force-injected for map keying when the caller's select did not ask for it,
+    // so returned values match the declared payload type and never leak an unrequested id.
+    const stripInjectedId = args?.select != null && !("id" in args.select);
     for (const row of rows) {
-      byId.set(row.id as string, row);
+      const key = row.id as string;
+      if (stripInjectedId) {
+        delete row.id;
+      }
+      byId.set(key, row);
     }
     return byId;
   }

internal-packages/run-store/src/runOpsStore.groupedReads.test.ts

@@ -178,7 +178,7 @@ describe("RoutingRunStore.findRunsByIds — grouped, residency-partitioned read
       newCounting.counts.findFirst = 0;
 
       const result = await router.findRunsByIds(allIds, {
-        select: { id: true, friendlyId: true },
+        select: { friendlyId: true },
       });
 
       // All N rows returned, keyed by id.
@@ -189,6 +189,10 @@ describe("RoutingRunStore.findRunsByIds — grouped, residency-partitioned read
       expect(result.get(legacyIds[0])?.friendlyId).toBe("run_grp_leg_0");
       expect(result.get(newIds[0])?.friendlyId).toBe("run_grp_new_0");
 
+      // The select omitted `id`; the id we force-inject for keying must not leak into the value.
+      expect("id" in (result.get(legacyIds[0]) as object)).toBe(false);
+      expect("id" in (result.get(newIds[0]) as object)).toBe(false);
+
       // GROUPED: exactly one findMany call per store queried (NEW always queried for the whole
       // set; LEGACY queried once more for the misses) — never N per-id findFirst calls.
       expect(newCounting.counts.findMany).toBe(1);

internal-packages/run-store/src/runOpsStore.ts

@@ -419,8 +419,15 @@ export class RoutingRunStore implements RunStore {
       client
     )) as Record<string, unknown>[];
     const byId = new Map<string, unknown>();
+    // Strip the id we force-injected for map keying when the caller's select did not ask for it,
+    // so returned values match the declared payload type and never leak an unrequested id.
+    const stripInjectedId = args?.select != null && !("id" in (args.select as object));
     for (const row of rows) {
-      byId.set(row.id as string, row);
+      const key = row.id as string;
+      if (stripInjectedId) {
+        delete row.id;
+      }
+      byId.set(key, row);
     }
     return byId;
   }