Skip to content

Commit e64d9ae

Browse files
committed
fix(webapp): tighten Override info-icon gap; Throttled reads 'of current period' (TRI-12068)
Pull the override explainer icon in to a gap-1 spacing from the 'Override' label (item 2). Change the Throttled chart readout from '{X}% of window' to '{X}% of current period' (item 4).
1 parent 0ecd768 commit e64d9ae

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -861,6 +861,9 @@ function QueuesWithMetricsView() {
861861
}
862862
contentClassName="max-w-[230px]"
863863
disableHoverableContent
864+
// Tighten the gap from the "Override" label to gap-1 (the cell's
865+
// trailing adornment gap is gap-2; -ml-1 pulls the icon in 4px).
866+
buttonClassName="-ml-1"
864867
/>
865868
) : undefined
866869
}
@@ -1197,8 +1200,8 @@ type QueueHeaderTile = {
11971200
/** Formats the y-axis tick labels. Without it the axis shows raw numbers (bad for durations
11981201
* in ms or percent scales). Passed through to Chart.Line's yAxisProps.tickFormatter. */
11991202
formatAxis?: (value: number) => string;
1200-
/** Hover tooltip explaining the headline readout next to the title (e.g. what "9% of window"
1201-
* means). Without it the readout has no tooltip. */
1203+
/** Hover tooltip explaining the headline readout next to the title (e.g. what "9% of current
1204+
* period" means). Without it the readout has no tooltip. */
12021205
totalTooltip?: string;
12031206
// Rows can be one-per-bucket (p95, throttled: aggregated across the set in ClickHouse) or
12041207
// one-per-(bucket, queue) (saturation, backlog: summed across the set here, since summing a
@@ -1346,7 +1349,7 @@ const QUEUE_HEADER_TILES: QueueHeaderTile[] = [
13461349
return {
13471350
points,
13481351
total: pct,
1349-
formatTotal: (v) => `${v}% of window`,
1352+
formatTotal: (v) => `${v}% of current period`,
13501353
totalClassName: pct > 0 ? "text-warning" : undefined,
13511354
};
13521355
},

0 commit comments

Comments
 (0)