Skip to content

Commit c1f7b2f

Browse files
d-csclaude
andcommitted
chore(webapp): drop internal phase labels from mollifier route comments
Comments referenced internal phase labels ("Phase A2", "Phase A5") from the development plan rather than describing what the code does. Replaced with self-contained prose; the surrounding explanations were already correct and are preserved. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 188b8c7 commit c1f7b2f

2 files changed

Lines changed: 11 additions & 11 deletions

File tree

apps/webapp/app/routes/api.v1.runs.$runId.spans.$spanId.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ const ParamsSchema = z.object({
1616
spanId: z.string(),
1717
});
1818

19-
// Phase A2 — discriminated union for PG vs buffered runs. Buffered runs
20-
// only have one valid spanId (the queued span recorded at gate time and
21-
// reused as the run's root spanId when the drainer materialises). Any
22-
// other spanId returns a deterministic 404; the queued span returns a
23-
// minimal synthesised shape so the customer's SDK sees the same 200
24-
// contract they'd get for a freshly-triggered run.
19+
// Resolve the run from either Postgres or the mollifier buffer.
20+
// Buffered runs only have one valid spanId (the queued span recorded at
21+
// gate time and reused as the run's root spanId when the drainer
22+
// materialises). Any other spanId returns a deterministic 404; the queued
23+
// span returns a minimal synthesised shape so the customer's SDK sees the
24+
// same 200 contract they'd get for a freshly-triggered run.
2525
type ResolvedRun =
2626
| { source: "pg"; run: Awaited<ReturnType<typeof findPgRun>> & {} }
2727
| { source: "buffer"; run: NonNullable<Awaited<ReturnType<typeof findRunByIdWithMollifierFallback>>> };

apps/webapp/app/routes/api.v1.runs.$runParam.attempts.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@ const ParamsSchema = z.object({
1818
runParam: z.string(),
1919
});
2020

21-
// Phase A5 — fixes the pre-existing route bug where GET on this URL
22-
// returned a Remix "no loader" 400 with an internal error message. The
23-
// route only exposed `action` (POST creates a new attempt); GET had no
24-
// handler, so any well-intentioned SDK probe hit the framework error
25-
// instead of a proper API response.
21+
// GET handler added to fix the pre-existing route bug where this URL
22+
// returned a Remix "no loader" 400 with an internal error message — only
23+
// `action` (POST creates a new attempt) was exported, so any
24+
// well-intentioned SDK probe hit the framework error instead of a proper
25+
// API response.
2626
//
2727
// Returns `{ attempts: [] }` for both PG and buffered runs. The detailed
2828
// attempt list belongs on the v3 retrieve endpoint, not here — this is

0 commit comments

Comments
 (0)