Skip to content

Commit aec6288

Browse files
committed
fix(webapp): only render the Help & Feedback chevron when expanded
The disclosure chevron is a hover affordance with no meaning in the collapsed rail, but it was left mounted there. Rendering it only when the side menu is expanded keeps the collapsed icon clean and stops the chevron slot from affecting the collapsed button's layout or paint.
1 parent aa15a48 commit aec6288

1 file changed

Lines changed: 10 additions & 11 deletions

File tree

apps/webapp/app/components/navigation/HelpAndFeedbackPopover.tsx

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -85,17 +85,16 @@ export function HelpAndFeedback({
8585
Help & Feedback
8686
</span>
8787
</span>
88-
{/* Up/down chevron revealed on hover, matching the Project menu button. */}
89-
<span
90-
className={cn(
91-
"overflow-hidden transition-[max-width] duration-200",
92-
isCollapsed
93-
? "max-w-0 opacity-0"
94-
: "max-w-[16px] opacity-0 group-hover:opacity-100"
95-
)}
96-
>
97-
<DropdownIcon className="size-4 min-w-4 text-text-dimmed group-hover:text-text-bright" />
98-
</span>
88+
{/*
89+
Up/down chevron revealed on hover, matching the Project menu button. Only
90+
rendered when expanded so it can never occupy space or paint over the
91+
collapsed icon (it is a hover affordance that has no meaning collapsed).
92+
*/}
93+
{!isCollapsed && (
94+
<span className="overflow-hidden transition-[max-width] duration-200 max-w-[16px] opacity-0 group-hover:opacity-100">
95+
<DropdownIcon className="size-4 min-w-4 text-text-dimmed group-hover:text-text-bright" />
96+
</span>
97+
)}
9998
</PopoverTrigger>
10099
}
101100
content={

0 commit comments

Comments
 (0)