Skip to content

Commit a11ec13

Browse files
samejrcursoragent
andcommitted
fix(webapp): drop external-link icon from SSO modal buttons
These buttons open the admin portal dialog rather than navigating away, so the top-right arrow icon was misleading. Keep it only on the genuinely external Contact us and Open in new tab actions. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 42c6c7c commit a11ec13

1 file changed

Lines changed: 6 additions & 18 deletions

File tree

  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.sso

apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.sso/route.tsx

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -558,7 +558,7 @@ function NoIdpOrgState({ onOpenPortal }: { onOpenPortal: () => void }) {
558558
title="Get started"
559559
description="Verify your email domains, then connect your identity provider."
560560
action={
561-
<Button variant="secondary/small" onClick={onOpenPortal} TrailingIcon={ArrowUpRightIcon}>
561+
<Button variant="secondary/small" onClick={onOpenPortal}>
562562
Start setup
563563
</Button>
564564
}
@@ -602,11 +602,7 @@ function NoActiveConnectionState({
602602
title="Domains"
603603
description="Verify the email domains your team signs in with. Connect your identity provider once a domain is verified."
604604
action={
605-
<Button
606-
variant="secondary/small"
607-
onClick={onOpenDomain}
608-
TrailingIcon={ArrowUpRightIcon}
609-
>
605+
<Button variant="secondary/small" onClick={onOpenDomain}>
610606
{domains.length > 0 ? "Add domain" : "Verify domain"}
611607
</Button>
612608
}
@@ -633,7 +629,7 @@ function NoActiveConnectionState({
633629
title="Identity provider"
634630
description="Connect Okta, Azure AD, Google Workspace, and more."
635631
action={
636-
<Button variant="secondary/small" onClick={onOpenSso} TrailingIcon={ArrowUpRightIcon}>
632+
<Button variant="secondary/small" onClick={onOpenSso}>
637633
Configure SSO
638634
</Button>
639635
}
@@ -754,11 +750,7 @@ function ActiveConnectionState({
754750
title="Domains"
755751
description="The email domains your team signs in with."
756752
action={
757-
<Button
758-
variant="secondary/small"
759-
onClick={() => onOpenPortal("domain_verification")}
760-
TrailingIcon={ArrowUpRightIcon}
761-
>
753+
<Button variant="secondary/small" onClick={() => onOpenPortal("domain_verification")}>
762754
{status.domains.length > 0 ? "Add domain" : "Verify domain"}
763755
</Button>
764756
}
@@ -777,11 +769,7 @@ function ActiveConnectionState({
777769
title="SSO"
778770
description={`SSO connection for ${orgTitle}.`}
779771
action={
780-
<Button
781-
variant="secondary/small"
782-
onClick={() => onOpenPortal("sso")}
783-
TrailingIcon={ArrowUpRightIcon}
784-
>
772+
<Button variant="secondary/small" onClick={() => onOpenPortal("sso")}>
785773
Manage connection
786774
</Button>
787775
}
@@ -969,7 +957,7 @@ function DirectorySyncSection({
969957
title="Directory Sync"
970958
description="Sync users and groups from your identity provider over SCIM. Members of mapped groups are provisioned with the group's role, and removing them from your directory revokes their access."
971959
action={
972-
<Button variant="secondary/small" onClick={onOpenPortal} TrailingIcon={ArrowUpRightIcon}>
960+
<Button variant="secondary/small" onClick={onOpenPortal}>
973961
{directorySync.directories.length === 0 ? "Connect a directory" : "Manage directory"}
974962
</Button>
975963
}

0 commit comments

Comments
 (0)