chore: trim inline comments to one-liners

Author: myftija

apps/webapp/app/env.server.ts

@@ -936,9 +936,7 @@ const EnvironmentSchema = z
 
     INTERNAL_OTEL_LOG_EXPORTER_URL: z.string().optional(),
 
-    // Optional second OTLP trace exporter that receives only `deployment.*`
-    // spans (deployment lifecycle analytics), e.g. a dedicated long-retention
-    // Axiom dataset. The spans also still flow to the main trace exporter.
+    // Second trace exporter receiving only `deployment.*` spans; they still flow to the main one
     INTERNAL_OTEL_DEPLOYMENT_EVENT_EXPORTER_URL: z.string().optional(),
     INTERNAL_OTEL_DEPLOYMENT_EVENT_EXPORTER_AUTH_HEADERS: z.string().optional(),
     INTERNAL_OTEL_METRIC_EXPORTER_URL: z.string().optional(),

apps/webapp/app/v3/deploymentTelemetry.ts

@@ -58,11 +58,10 @@ export const DeploymentTelemetryAttributes = {
 export type DeploymentBuildPath = "local_bundle" | "native" | "depot";
 
 /**
- * Classifies which build path produced a deployment, from its persisted
- * metadata. Everything that is not a native-build-server deployment falls into
- * the depot bucket — including rare `--local-build` deploys, whose flag is not
- * persisted. `externalBuildData` is NOT usable as a depot signal: init writes a
- * placeholder (`"-"` fields) for every path.
+ * Everything that is not a native-build-server deployment falls into the depot
+ * bucket, including rare `--local-build` deploys (their flag is not persisted).
+ * `externalBuildData` is NOT a usable depot signal: init writes a placeholder
+ * for every path.
  */
 export function deriveBuildPath(buildServerMetadata: unknown): DeploymentBuildPath {
   const metadata = BuildServerMetadata.safeParse(buildServerMetadata);
@@ -90,11 +89,9 @@ export type DeploymentDurations = {
 };
 
 /**
- * Derives per-phase durations from the persisted timestamp chain
- * (createdAt → startedAt → installedAt → builtAt → terminal). Chains are
- * path-shaped: depot never sets installedAt (the /progress route is
- * build-server-only) and PENDING-skipping deploys have queue ≈ 0 — each phase
- * is emitted only when both of its boundary timestamps exist and are ordered.
+ * Timestamp chains are path-shaped (e.g. depot never sets installedAt), so
+ * each phase is derived only when both of its boundary timestamps exist and
+ * are ordered.
  */
 export function deriveDeploymentDurations(
   timestamps: DeploymentTimestamps,

apps/webapp/app/v3/services/deployment.server.ts

@@ -483,8 +483,7 @@ export class DeploymentService extends BaseService {
     );
   }
 
-  // The cancel path only carries a narrow row selection, so re-fetch the full
-  // row (post-update, status already CANCELED) for the lifecycle event.
+  // The cancel chain only carries a narrow row selection, so re-fetch the full row
   #recordCanceledLifecycle(deploymentId: string) {
     return fromPromise(
       this._prisma.workerDeployment.findFirst({

apps/webapp/app/v3/services/failDeployment.server.ts

@@ -43,9 +43,7 @@ export class FailDeploymentService extends BaseService {
 
     const failedAt = new Date();
 
-    // Guarded transition: a concurrent finalize/timeout/cancel can win between
-    // the check above and this write; the predicate makes exactly one caller
-    // commit the terminal status (and emit the lifecycle event).
+    // Guarded: a concurrent terminal transition can win after the check above
     const { count: updatedCount } = await this._prisma.workerDeployment.updateMany({
       where: {
         id: deployment.id,
@@ -67,9 +65,7 @@ export class FailDeploymentService extends BaseService {
       return;
     }
 
-    // Re-read after the guarded write: the row can gain phase timestamps
-    // between the initial read and the update, and callers expect the
-    // post-update row.
+    // Re-read: the row can gain phase timestamps between the read and the guarded write
     const failedDeployment = await this._prisma.workerDeployment.findFirst({
       where: { id: deployment.id },
     });

apps/webapp/app/v3/services/finalizeDeployment.server.ts

@@ -71,10 +71,7 @@ export class FinalizeDeploymentService extends BaseService {
       ? `${deployment.imageReference}@${imageDigest}`
       : deployment.imageReference;
 
-    // Guarded transition: a concurrent timeout/fail/cancel can win between the
-    // status check above and this write; the predicate makes exactly one caller
-    // commit the terminal status (and emit the lifecycle event). It also stops
-    // a late timeout from overwriting DEPLOYED.
+    // Guarded: stops a concurrent transition (e.g. a late timeout) from double-committing
     const { count: updatedCount } = await this._prisma.workerDeployment.updateMany({
       where: {
         id: deployment.id,

apps/webapp/app/v3/services/recordDeploymentLifecycle.server.ts

@@ -46,15 +46,11 @@ type EnvironmentInfo = {
 
 /**
  * Records a deployment's terminal transition as a single wide
- * `deployment.lifecycle` span, backdated to span the deployment's real
- * lifetime (createdAt → terminal) and carrying per-phase durations as
- * attributes. This is THE per-deployment analytics event: build-path
- * comparison dashboards and monitors are built on it (the attribute contract
- * lives in ../deploymentTelemetry.ts).
- *
- * Call exactly once per terminal transition, only after a guarded status
- * write confirmed this caller won the transition. Emitted on ROOT_CONTEXT
- * with forceRecording so the trace sampler can never drop it. Never throws.
+ * `deployment.lifecycle` span, backdated createdAt → terminal (attribute
+ * contract in ../deploymentTelemetry.ts). Call exactly once, only after a
+ * guarded status write confirmed this caller won the transition. Emitted on
+ * ROOT_CONTEXT with forceRecording so the sampler can never drop it; never
+ * throws.
  */
 export function recordDeploymentLifecycle(params: {
   status: TerminalDeploymentStatus;
@@ -106,8 +102,7 @@ export function recordDeploymentLifecycle(params: {
       ROOT_CONTEXT
     );
 
-    // CANCELED is deliberately not an error: it is excluded from failure
-    // rates and tracked as its own volume.
+    // CANCELED is deliberately not an error: it stays out of failure rates
     if (isFailure) {
       span.setStatus({
         code: SpanStatusCode.ERROR,
@@ -126,9 +121,8 @@ export function recordDeploymentLifecycle(params: {
 
 /**
  * Records a deployment's creation as a zero-duration `deployment.initialized`
- * event, the funnel counterpart to `deployment.lifecycle`: an initialized
- * deployment with no lifecycle event after a few hours is either stuck
- * non-terminal or hit an emission bug. Never throws.
+ * event — the funnel counterpart to `deployment.lifecycle` for detecting
+ * stuck deployments. Never throws.
  */
 export function recordDeploymentInitialized(params: {
   deployment: Pick<

apps/webapp/app/v3/services/timeoutDeployment.server.ts

@@ -41,9 +41,7 @@ export class TimeoutDeploymentService extends BaseService {
     const failedAt = new Date();
     const errorData = { message: errorMessage, name: "TimeoutError" };
 
-    // Guarded transition: keeps the fromStatus check atomic with the write, so
-    // a concurrent finalize/fail/cancel can't be overwritten by a late timeout
-    // (and exactly one caller emits the lifecycle event).
+    // Guarded: keeps the fromStatus check atomic with the write
     const { count: updatedCount } = await this._prisma.workerDeployment.updateMany({
       where: {
         id: deployment.id,

apps/webapp/app/v3/tracer.server.ts

@@ -91,9 +91,7 @@ class DatasourceAttributeSpanProcessor implements SpanProcessor {
   }
 }
 
-// Mirrors spans whose name matches a prefix into a second exporter (e.g. the
-// dedicated deployment-events dataset) without removing them from the main
-// exporter's stream.
+// Mirrors name-prefixed spans into a second exporter; they still flow to the main one
 class SpanNamePrefixMirrorProcessor implements SpanProcessor {
   constructor(
     private readonly _inner: SpanProcessor,
@@ -392,9 +390,7 @@ function setupTelemetry() {
     instrumentations,
   });
 
-  // closeServer only closes express and lets the process drain, so a flush
-  // here has time to run — without it every webapp shutdown drops the last
-  // batch of spans (up to 1s of scheduledDelayMillis backlog).
+  // Without this flush every shutdown drops the last batch of spans
   const flushOnShutdown = () => {
     provider.forceFlush().catch(() => {});
   };

internal-packages/database/prisma/migrations/20260825120000_add_worker_deployment_cli_version/migration.sql

@@ -1,2 +1 @@
--- Stamp the initiating CLI version on deployments at initialization
 ALTER TABLE "public"."WorkerDeployment" ADD COLUMN IF NOT EXISTS "cliVersion" TEXT;

internal-packages/database/prisma/schema.prisma

@@ -2265,8 +2265,7 @@ model WorkerDeployment {
 
   runtime        String?
   runtimeVersion String?
-  /// CLI version that initiated the deploy (x-trigger-cli-version), stamped at
-  /// initialization so pre-index failures are attributable to a CLI version.
+  /// CLI version that initiated the deploy, stamped at initialization
   cliVersion     String?
 
   imageReference String?