Skip to content

Commit 98e8272

Browse files
committed
fix(webapp): log run-engine ClickHouse factory failures at error level
Factory resolution failures (registry misload, missing data store, ClientType mismatch) are configuration problems, not transient blips, and ops loses observability if they only surface as warnings. Query- level errors stay at warn since those are expected to be transient.
1 parent ff6db49 commit 98e8272

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

apps/webapp/app/v3/services/clickhousePendingVersionLookup.server.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,12 @@ export class ClickhousePendingVersionLookup implements PendingVersionRunIdLookup
4747
"engine"
4848
);
4949
} catch (error) {
50-
this.opts.logger.warn("ClickhousePendingVersionLookup factory resolution failed", {
50+
// Factory resolution failures usually mean a real configuration
51+
// problem (registry misload, missing data store, ClientType mismatch).
52+
// These are not transient — log at error so ops sees them in dashboards
53+
// and incident hooks. Query-level errors below stay at warn because
54+
// those are expected to be transient.
55+
this.opts.logger.error("ClickhousePendingVersionLookup factory resolution failed", {
5156
error,
5257
organizationId: options.organizationId,
5358
});

0 commit comments

Comments
 (0)