Skip to content

Commit 81ffb3f

Browse files
committed
docs(core): clarify what the workload resume retry covers
The database-outage retry lives on the supervisor-to-engine hop; the workload client only reaches the supervisor's workload server, so its retry rides out supervisor blips (e.g. a restart), not DB outages. Fix the comment to say so.
1 parent 8334820 commit 81ffb3f

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

  • packages/core/src/v3/runEngineWorker/workload

packages/core/src/v3/runEngineWorker/workload/http.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -134,11 +134,11 @@ export class WorkloadHttpClient {
134134
},
135135
},
136136
{
137-
// Resuming after a wait is idempotent (guarded server-side by the
138-
// snapshot id), so retry generously to ride out a transient database
139-
// outage rather than aborting the run. `randomize` jitters the delay
140-
// so a fleet of runs resuming at once doesn't stampede the DB the
141-
// moment it recovers.
137+
// This hop only reaches the supervisor's workload server, so retry
138+
// generously with jittered backoff to ride out a transient blip
139+
// talking to the supervisor (e.g. a restart) rather than aborting the
140+
// run. Database outages surface one hop further in, on the
141+
// supervisor-to-engine call, which carries its own retry for them.
142142
retry: {
143143
minTimeoutInMs: 500,
144144
maxTimeoutInMs: 10_000,

0 commit comments

Comments
 (0)