Skip to content

Commit 6de11e8

Browse files
committed
fix devin comments
1 parent 91f6d81 commit 6de11e8

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.claude/REVIEW.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Reserve 🔴 for things that would page someone or block a rollback. In this cod
2525

2626
- **Tests use testcontainers, not mocks.** Vitest with `redisTest` / `postgresTest` / `containerTest` from `@internal/testcontainers`. Any new `vi.mock(...)` on Redis, Postgres, BullMQ, or other infra is wrong here — 🔴 if added in production-path tests, 🟡 if isolated unit test.
2727
- **Public-package changes have a changeset.** `pnpm run changeset:add` produces `.changeset/*.md`. Required for any edit under `packages/*`. Missing → 🟡; missing on a breaking change → 🔴.
28-
- **Server-only changes have `.server-changes/*.md`.** Required for `apps/webapp/`, `apps/supervisor/` edits with no public-package change. Body should be 1-2 sentences (it has to fit as one bullet in a future changelog). Missing → 🟡.
28+
- **Server changes have `.server-changes/*.md`.** Required for `apps/webapp/`, `apps/supervisor/` edits. Body should be 1-2 sentences (it has to fit as one bullet in a future changelog). Missing → 🟡.
2929
- **Lua script naming.** Coexisting scripts use behavior-descriptive suffixes (`Tracked`), never `V2`. Old name must keep working until the next deploy clears it.
3030
- **RunQueue payload shape.** V2 run-queue payload's `projectId` is consumed by `workerQueueResolver` for override matching. If a PR drops it from the payload, 🔴.
3131
- **`safeSend` scope.** Defensive IPC wrappers belong on loop / interval / handler contexts, not one-shot terminal sends. If the PR adds `safeSend` to a single terminal call for consistency, 🟡 with a "remove this" suggestion.

CHANGESETS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ EOF
2424
- `area`: `webapp` | `supervisor` | `coordinator` | `kubernetes-provider` | `docker-provider`
2525
- `type`: `feature` | `fix` | `improvement` | `breaking`
2626

27-
For **mixed PRs** (both packages and server): just add a changeset. No `.server-changes/` file needed.
27+
For **mixed PRs** (both packages and server): add both a changeset and a .server-changes file.
2828

2929
See `.server-changes/README.md` for full documentation.
3030

0 commit comments

Comments
 (0)