fix(webapp): consistent deployment.outcome attributes (env on bgworker-fail; drop unused CANCELED)

Author: nicktrn

apps/webapp/app/v3/services/createDeploymentBackgroundWorkerV4.server.ts

@@ -112,7 +112,7 @@ export class CreateDeploymentBackgroundWorkerServiceV4 extends BaseService {
         if (findOrCreateError instanceof ServiceValidationError) {
           // `#failBackgroundWorkerDeployment` already throws its argument; the
           // outer `throw` covers the non-SVE branch.
-          await this.#failBackgroundWorkerDeployment(deployment, findOrCreateError);
+          await this.#failBackgroundWorkerDeployment(deployment, findOrCreateError, environment);
         }
         throw findOrCreateError;
       }
@@ -145,7 +145,7 @@ export class CreateDeploymentBackgroundWorkerServiceV4 extends BaseService {
 
         const serviceError = new ServiceValidationError("Error creating background worker files");
 
-        await this.#failBackgroundWorkerDeployment(deployment, serviceError);
+        await this.#failBackgroundWorkerDeployment(deployment, serviceError, environment);
 
         throw serviceError;
       }
@@ -168,7 +168,7 @@ export class CreateDeploymentBackgroundWorkerServiceV4 extends BaseService {
             error: resourcesError.message,
           });
 
-          await this.#failBackgroundWorkerDeployment(deployment, resourcesError);
+          await this.#failBackgroundWorkerDeployment(deployment, resourcesError, environment);
           throw resourcesError;
         }
 
@@ -180,7 +180,7 @@ export class CreateDeploymentBackgroundWorkerServiceV4 extends BaseService {
           "Error creating background worker resources"
         );
 
-        await this.#failBackgroundWorkerDeployment(deployment, serviceError);
+        await this.#failBackgroundWorkerDeployment(deployment, serviceError, environment);
 
         throw serviceError;
       }
@@ -207,7 +207,7 @@ export class CreateDeploymentBackgroundWorkerServiceV4 extends BaseService {
             error: schedulesError.message,
           });
 
-          await this.#failBackgroundWorkerDeployment(deployment, schedulesError);
+          await this.#failBackgroundWorkerDeployment(deployment, schedulesError, environment);
           throw schedulesError;
         }
 
@@ -221,7 +221,7 @@ export class CreateDeploymentBackgroundWorkerServiceV4 extends BaseService {
 
         const serviceError = new ServiceValidationError("Error syncing declarative schedules");
 
-        await this.#failBackgroundWorkerDeployment(deployment, serviceError);
+        await this.#failBackgroundWorkerDeployment(deployment, serviceError, environment);
 
         throw serviceError;
       }
@@ -265,7 +265,11 @@ export class CreateDeploymentBackgroundWorkerServiceV4 extends BaseService {
     });
   }
 
-  async #failBackgroundWorkerDeployment(deployment: WorkerDeployment, error: Error) {
+  async #failBackgroundWorkerDeployment(
+    deployment: WorkerDeployment,
+    error: Error,
+    environment: AuthenticatedEnvironment
+  ) {
     // Guarded BUILDING → FAILED transition, symmetric with the BUILDING → DEPLOYING
     // transition in `call()`. With idempotent retries, two attempts can run side-by-side;
     // without the predicate, one attempt's failure could downgrade the deployment after
@@ -302,8 +306,10 @@ export class CreateDeploymentBackgroundWorkerServiceV4 extends BaseService {
       recordDeploymentOutcome({
         status: "FAILED",
         deploymentFriendlyId: deployment.friendlyId,
-        projectId: deployment.projectId,
-        environmentId: deployment.environmentId,
+        organizationId: environment.organizationId,
+        projectId: environment.projectId,
+        environmentId: environment.id,
+        environmentType: environment.type,
         reason: error.message,
       });
     }

apps/webapp/app/v3/services/recordDeploymentOutcome.server.ts

@@ -5,7 +5,7 @@ import { tracer } from "~/v3/tracer.server";
 
 type TerminalDeploymentStatus = Extract<
   WorkerDeploymentStatus,
-  "DEPLOYED" | "FAILED" | "TIMED_OUT" | "CANCELED"
+  "DEPLOYED" | "FAILED" | "TIMED_OUT"
 >;
 
 /**