fix: redirect with error toast instead of raw json on denied dashboard management actions

Author: nicktrn

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.regions/route.tsx

@@ -7,7 +7,7 @@ import {
   MapPinIcon,
 } from "@heroicons/react/20/solid";
 import { Form } from "@remix-run/react";
-import { json, type LoaderFunctionArgs } from "@remix-run/server-runtime";
+import { type LoaderFunctionArgs } from "@remix-run/server-runtime";
 import { tryCatch } from "@trigger.dev/core";
 import { useState } from "react";
 import { typedjson, useTypedLoaderData } from "remix-typedjson";
@@ -103,18 +103,22 @@ export const action = dashboardAction(
   async ({ user, ability, request, params }) => {
     const { organizationSlug, projectParam, envParam } = params;
 
-    if (!ability.can("manage", { type: "project" })) {
-      return json({ ok: false, error: "Unauthorized" } as const, { status: 403 });
-    }
-
-    const project = await findProjectBySlug(organizationSlug, projectParam, user.id);
-
     const redirectPath = regionsPath(
       { slug: organizationSlug },
       { slug: projectParam },
       { slug: envParam }
     );
 
+    if (!ability.can("manage", { type: "project" })) {
+      throw redirectWithErrorMessage(
+        redirectPath,
+        request,
+        "You don't have permission to change the default region"
+      );
+    }
+
+    const project = await findProjectBySlug(organizationSlug, projectParam, user.id);
+
     if (!project) {
       throw redirectWithErrorMessage(redirectPath, request, "Project not found");
     }

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.settings.general/route.tsx

@@ -106,7 +106,11 @@ export const action = dashboardAction(
     switch (submission.value.action) {
       case "rename": {
         if (!ability.can("manage", { type: "project" })) {
-          return json({ ok: false, error: "Unauthorized" } as const, { status: 403 });
+          throw redirectWithErrorMessage(
+            v3ProjectPath({ slug: organizationSlug }, { slug: projectParam }),
+            request,
+            "You don't have permission to rename this project"
+          );
         }
         const resultOrFail = await projectSettingsService.renameProject(
           projectId,
@@ -135,7 +139,11 @@ export const action = dashboardAction(
       }
       case "delete": {
         if (!ability.can("manage", { type: "project" })) {
-          return json({ ok: false, error: "Unauthorized" } as const, { status: 403 });
+          throw redirectWithErrorMessage(
+            v3ProjectPath({ slug: organizationSlug }, { slug: projectParam }),
+            request,
+            "You don't have permission to delete this project"
+          );
         }
         const resultOrFail = await projectSettingsService.deleteProject(projectId, userId);
 

apps/webapp/app/routes/_app.orgs.$organizationSlug.settings._index/route.tsx

@@ -177,7 +177,11 @@ export const action = dashboardAction(
       switch (submission.value.action) {
         case "rename": {
           if (!ability.can("manage", { type: "organization" })) {
-            return json({ ok: false, error: "Unauthorized" } as const, { status: 403 });
+            throw redirectWithErrorMessage(
+              organizationSettingsPath({ slug: organizationSlug }),
+              request,
+              "You don't have permission to rename this organization"
+            );
           }
           await prisma.organization.update({
             where: {
@@ -201,7 +205,11 @@ export const action = dashboardAction(
         }
         case "delete": {
           if (!ability.can("manage", { type: "organization" })) {
-            return json({ ok: false, error: "Unauthorized" } as const, { status: 403 });
+            throw redirectWithErrorMessage(
+              organizationSettingsPath({ slug: organizationSlug }),
+              request,
+              "You don't have permission to delete this organization"
+            );
           }
           const deleteOrganizationService = new DeleteOrganizationService();
           try {