fix: address coderabbit feedback on zod v4 migration

- core: forward the validated/normalized payload (parsedPayload.data)
  from the zod message sender instead of casting the raw input, so zod
  transforms, defaults, and coercions are applied on send
- webapp: reword the feedback type union error to cover all feedback
  types, not just bug/feature

Author: carderne

apps/webapp/app/routes/resources.feedback.ts

@@ -61,7 +61,7 @@ const feedbackTypeLiterals = Object.keys(feedbackTypes).map((key) => z.literal(k
 const feedbackType = z.union(
   [feedbackTypeLiterals[0], feedbackTypeLiterals[1], ...feedbackTypeLiterals.slice(2)],
   {
-    error: "Must be either 'bug' or 'feature'",
+    error: "Must be a valid feedback type",
   }
 );
 

packages/core/src/v3/zodMessageHandler.ts

@@ -278,8 +278,8 @@ export class ZodMessageSender<TMessageCatalog extends ZodMessageCatalogSchema> {
     }
 
     try {
-      // send side: payload is input; zod v4 distinguishes input/output on the sender signature
-      await this.#sender({ type, payload: payload as any, version: "v1" });
+      // send the validated/normalized output so zod transforms, defaults, and coercions are applied
+      await this.#sender({ type, payload: parsedPayload.data, version: "v1" });
     } catch (error) {
       console.error("[ZodMessageSender] Failed to send message", error);
     }
@@ -334,8 +334,8 @@ export async function sendMessageInCatalog<TMessageCatalog extends ZodMessageCat
     throw new ZodSchemaParsedError(parsedPayload.error, payload);
   }
 
-  // send side: payload is input; zod v4 distinguishes input/output on the sender signature
-  await sender({ type, payload: payload as any, version: "v1" });
+  // send the validated/normalized output so zod transforms, defaults, and coercions are applied
+  await sender({ type, payload: parsedPayload.data, version: "v1" });
 }
 
 export type MessageCatalogToSocketIoEvents<TCatalog extends ZodMessageCatalogSchema> = {