fix: address CodeRabbit review feedback

- Fix manual config for unsupported clients to include all new flags
- Improve environment parsing to handle edge cases (empty strings, duplicates)
- Normalize environment names (lowercase, trim) for consistent matching
- Ensure envOnly takes precedence over devOnly in all places

Signed-off-by: Andy <andy+github@savage.hk>

Author: hongkongkiwi

packages/cli-v3/src/commands/install-mcp.ts

@@ -287,10 +287,21 @@ function handleUnsupportedClientOnly(options: InstallMcpCommandOptions): Install
     args.push("--api-url", options.apiUrl);
   }
 
-  if (options.devOnly) {
+  // Handle environment restrictions - envOnly takes precedence
+  if (options.envOnly) {
+    args.push("--env-only", options.envOnly);
+  } else if (options.devOnly) {
     args.push("--dev-only");
   }
 
+  if (options.disableDeployment) {
+    args.push("--disable-deployment");
+  }
+
+  if (options.readonly) {
+    args.push("--readonly");
+  }
+
   if (options.projectRef) {
     args.push("--project-ref", options.projectRef);
   }

packages/cli-v3/src/commands/mcp.ts

@@ -130,7 +130,15 @@ export async function mcpCommand(options: McpCommandOptions) {
   // Parse envOnly into an array if provided
   let envOnly: string[] | undefined;
   if (options.envOnly) {
-    envOnly = options.envOnly.split(',').map(env => env.trim());
+    // Parse, normalize, and deduplicate environments
+    envOnly = Array.from(
+      new Set(
+        options.envOnly
+          .split(',')
+          .map(env => env.trim().toLowerCase())
+          .filter(Boolean) // Remove empty strings
+      )
+    );
 
     // Validate environment names
     const validEnvironments = ['dev', 'staging', 'prod', 'preview'];

packages/cli-v3/src/mcp/context.ts

@@ -189,9 +189,13 @@ export class McpContext {
   }
 
   public isEnvironmentAllowed(environment: string): boolean {
+    // Normalize the environment name for comparison
+    const normalizedEnv = environment.trim().toLowerCase();
+
     // If envOnly is specified, use that (devOnly is already converted to envOnly)
     if (this.options.envOnly && this.options.envOnly.length > 0) {
-      return this.options.envOnly.includes(environment);
+      // Note: envOnly is already normalized to lowercase in mcp.ts
+      return this.options.envOnly.includes(normalizedEnv);
     }
 
     // If no restrictions, all environments are allowed