Skip to content

Commit 1ef1aae

Browse files
committed
fix(webapp): prune carried assets before overlaying the current build
Pruning before the current build lands makes the current build's assets unreachable by the prune, whatever mtimes the builder produces - a broken prune can only mean slow image growth, never a broken image.
1 parent 52ff029 commit 1ef1aae

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

docker/Dockerfile

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,11 +93,14 @@ COPY --from=production-deps --chown=node:node /triggerdotdev .
9393
COPY --from=dev-deps --chown=node:node /triggerdotdev/internal-packages/database/generated ./internal-packages/database/generated
9494
COPY --from=builder --chown=node:node /triggerdotdev/apps/webapp/build/server.js ./apps/webapp/build/server.js
9595
COPY --from=builder --chown=node:node /triggerdotdev/apps/webapp/build ./apps/webapp/build
96-
# Previous assets first, current build on top; prune >14d (COPY keeps mtimes).
96+
# Previous assets, pruned to a 14-day window (COPY keeps mtimes), then the
97+
# current build on top. Pruning BEFORE the overlay means the current build's
98+
# assets can never be deleted, whatever mtimes the builder produces — a
99+
# broken prune can only mean slow image growth, never a broken image.
97100
COPY --from=prev-assets --chown=node:node /triggerdotdev/apps/webapp/public/build ./apps/webapp/public/build
98-
COPY --from=builder --chown=node:node /triggerdotdev/apps/webapp/public ./apps/webapp/public
99101
RUN find ./apps/webapp/public/build -type f -mtime +14 -delete \
100102
&& find ./apps/webapp/public/build -type d -empty -delete
103+
COPY --from=builder --chown=node:node /triggerdotdev/apps/webapp/public ./apps/webapp/public
101104
COPY --from=builder --chown=node:node /triggerdotdev/scripts ./scripts
102105

103106
# Goose and schemas

0 commit comments

Comments
 (0)