Skip to content

Commit 0de4601

Browse files
d-csclaude
andcommitted
chore(webapp): strip remaining phase labels from mollifier mutation route comments
Two Phase labels survived the earlier sweep — "Phase A6" in api.v1.runs.\$runId.metadata.ts (the GET-loader-added comment, mirroring the same pattern in api.v1.runs.\$runParam.attempts.ts on reads), and "Phase B4" in api.v1.runs.\$runParam.replay.ts (referring to where SyntheticRun was extended). Rewritten to plain prose; comment-only, no behaviour change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 58ef2a6 commit 0de4601

2 files changed

Lines changed: 7 additions & 8 deletions

File tree

apps/webapp/app/routes/api.v1.runs.$runId.metadata.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ const ParamsSchema = z.object({
1818
runId: z.string(),
1919
});
2020

21-
// Phase A6 — fixes the pre-existing route bug where GET on this URL
22-
// returned a Remix "no loader" 400. The route only exposed PUT (update);
21+
// GET handler added to fix the pre-existing route bug where this URL
22+
// returned a Remix "no loader" 400only PUT (update) was exported, so
2323
// GET had no handler. Returns `{ metadata, metadataType }` from either
2424
// the Postgres row or the mollifier buffer snapshot.
2525
export async function loader({ request, params }: LoaderFunctionArgs) {

apps/webapp/app/routes/api.v1.runs.$runParam.replay.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,11 @@ export async function action({ request, params }: ActionFunctionArgs) {
7373
});
7474

7575
if (!taskRun) {
76-
// Buffered fallback. The SyntheticRun shape was extended in
77-
// Phase B4 to carry every field ReplayTaskRunService reads from a
78-
// TaskRun. Validate the subset of fields the service consumes
79-
// (BufferedReplayInputSchema above) before casting; a schema
80-
// mismatch surfaces as a 404 here rather than as a silent
81-
// undefined deep inside the service.
76+
// Buffered fallback. SyntheticRun carries every field
77+
// ReplayTaskRunService reads from a TaskRun. Validate the subset of
78+
// fields the service consumes (BufferedReplayInputSchema above)
79+
// before casting; a schema mismatch surfaces as a 404 here rather
80+
// than as a silent undefined deep inside the service.
8281
const buffered = await findRunByIdWithMollifierFallback({
8382
runId: runParam,
8483
environmentId: env.id,

0 commit comments

Comments
 (0)