Skip to content

Commit 067b0d3

Browse files
committed
fix(webapp): fix promo page heading typography
The promo page stretched Header2 to display sizes, but Header2's fixed leading-6 collapsed the multi-line title so the two lines overlapped. Switch to Header1 (the page-title primitive, used by the login pages) with leading-tight and pb-4 for correct line-height and spacing.
1 parent b902e65 commit 067b0d3

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

apps/webapp/app/routes/promo.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { LoginPageLayout } from "~/components/LoginPageLayout";
88
import { Button, LinkButton } from "~/components/primitives/Buttons";
99
import { Callout } from "~/components/primitives/Callout";
1010
import { Fieldset } from "~/components/primitives/Fieldset";
11-
import { Header2 } from "~/components/primitives/Headers";
11+
import { Header1 } from "~/components/primitives/Headers";
1212
import { Paragraph } from "~/components/primitives/Paragraph";
1313
import { TextLink } from "~/components/primitives/TextLink";
1414
import { isGithubAuthSupported, isGoogleAuthSupported } from "~/services/auth.server";
@@ -139,9 +139,9 @@ export default function PromoPage() {
139139
<div className="flex w-full flex-col">
140140
{data.view === "signed_in" ? (
141141
<>
142-
<Header2 className="sm:text-2xl md:text-3xl lg:text-4xl" spacing>
142+
<Header1 className="pb-4 leading-tight sm:text-2xl md:text-3xl lg:text-4xl">
143143
Promo codes are for new accounts
144-
</Header2>
144+
</Header1>
145145
<Paragraph variant="base" spacing>
146146
You're already signed in. Promo credits can only be added to a brand-new account.
147147
</Paragraph>
@@ -151,11 +151,11 @@ export default function PromoPage() {
151151
</>
152152
) : (
153153
<>
154-
<Header2 className="sm:text-2xl md:text-3xl lg:text-4xl" spacing>
154+
<Header1 className="pb-4 leading-tight sm:text-2xl md:text-3xl lg:text-4xl">
155155
{data.view === "valid"
156156
? `Claim ${formatDollars(data.amountInCents)} credits`
157157
: "Create your account"}
158-
</Header2>
158+
</Header1>
159159
{data.view === "valid" ? (
160160
<Paragraph variant="base" spacing>
161161
These are only available for new accounts on the Free plan.

0 commit comments

Comments
 (0)