Skip to content

Commit acfe8a0

Browse files
authored
Ad-hoc sign release to not drop required entitlements (#84)
* Ad-hoc sign release to not drop required entitlements * Bump patch version
1 parent c190a26 commit acfe8a0

2 files changed

Lines changed: 5 additions & 8 deletions

File tree

.github/workflows/build_release.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,7 @@ jobs:
2929
-configuration Release \
3030
-archivePath Cilicon.xcarchive \
3131
-destination 'generic/platform=macOS' \
32-
CODE_SIGN_IDENTITY='' \
33-
CODE_SIGN_STYLE='Manual' \
34-
CODE_SIGNING_REQUIRED=NO \
35-
CODE_SIGNING_ALLOWED=NO \
32+
CODE_SIGN_IDENTITY='-' \
3633
CURRENT_PROJECT_VERSION=${{ github.run_number }} \
3734
ARCHS=arm64 \
3835
ONLY_ACTIVE_ARCH=NO \
@@ -49,11 +46,11 @@ jobs:
4946
version=$(/usr/libexec/PlistBuddy -c "Print :CFBundleShortVersionString" Cilicon.xcarchive/Products/Applications/Cilicon.app/Contents/Info.plist)
5047
build=$(/usr/libexec/PlistBuddy -c "Print :CFBundleVersion" Cilicon.xcarchive/Products/Applications/Cilicon.app/Contents/Info.plist)
5148
if [ "${{ github.event_name }}" = "release" ]; then
52-
echo "name=Cilicon_${version}_${build}_unsigned.zip" >> $GITHUB_OUTPUT
49+
echo "name=Cilicon_${version}_${build}_adhoc.zip" >> $GITHUB_OUTPUT
5350
else
5451
sha_short="${{ github.sha }}"
5552
sha_short="${sha_short:0:7}"
56-
echo "name=Cilicon_${version}_${build}_${sha_short}_unsigned.zip" >> $GITHUB_OUTPUT
53+
echo "name=Cilicon_${version}_${build}_${sha_short}_adhoc.zip" >> $GITHUB_OUTPUT
5754
fi
5855
5956
- name: Create ZIP Archive

Cilicon.xcodeproj/project.pbxproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,7 @@
386386
"$(inherited)",
387387
"@executable_path/../Frameworks",
388388
);
389-
MARKETING_VERSION = 2.4.0;
389+
MARKETING_VERSION = 2.4.1;
390390
PRODUCT_BUNDLE_IDENTIFIER = com.traderepublic.cilicon;
391391
PRODUCT_NAME = "$(TARGET_NAME)";
392392
PROVISIONING_PROFILE_SPECIFIER = "";
@@ -420,7 +420,7 @@
420420
"$(inherited)",
421421
"@executable_path/../Frameworks",
422422
);
423-
MARKETING_VERSION = 2.4.0;
423+
MARKETING_VERSION = 2.4.1;
424424
PRODUCT_BUNDLE_IDENTIFIER = com.traderepublic.cilicon;
425425
PRODUCT_NAME = "$(TARGET_NAME)";
426426
PROVISIONING_PROFILE_SPECIFIER = "";

0 commit comments

Comments
 (0)