Skip to content

[PROD RELEASE] - Updates & Fixes#1857

Merged
kkartunov merged 53 commits into
masterfrom
dev
May 19, 2026
Merged

[PROD RELEASE] - Updates & Fixes#1857
kkartunov merged 53 commits into
masterfrom
dev

Conversation

@kkartunov
Copy link
Copy Markdown
Collaborator

Related JIRA Ticket:

https://topcoder.atlassian.net/browse/

What's in this PR?

jmgasper and others added 30 commits May 13, 2026 11:31
Pm 4816
Copilot App: UI issue when opportunity name is too long
…/PM users without full access to the project
PM-4818 - Copilot App: Updated Text editor for Project Overview
…proval-view-in-wm

Pm 5065 challenges approval view in wm
…only-review-mode

PM-5015 - re-enable ai-only review mode
…ovals-list

PM-5065 - Paginate the list for budget approvals
…ovals-list

PM-5065 paginate approvals list
Updated Text Editor for Copilot Opportunity Overview
…ovals-list

PM-5065 - remove challenges filter
…ovals-list

Do not filter approval challenges by memberid
himaniraghav3 and others added 23 commits May 15, 2026 17:58
What was broken
Completed challenge billing rows could still show the ledger total as Member Payments for non-admin users when markup data was hidden or unavailable, so rows such as a $33.25 consumed charge displayed as $33.25 with a $10.97 fee instead of $25.00 with an $8.25 fee.

Root cause
The prior fixes correctly handled locked challenge rows and markup-based fallbacks, but the modal ignored API-provided member-payment subtotals for all challenge rows. That was too broad: locked rows must ignore those aliases, while consumed rows can use them as the exact completed member-payment subtotal.

What was changed
Consumed challenge rows now prefer `memberPaymentAmount` when it is present. For manager/admin views, the challenge fee is derived from the consumed ledger amount minus that member-payment subtotal before falling back to markup-based calculation.

Any added/updated tests
Added BillingAccountLineItemsModal regression coverage for consumed challenge rows where challenge markup cannot be loaded, covering both fee-visible users and copilot-safe views.
What was broken

Review app admins could copy Topgear Task submission IDs, but they had no inline way to re-raise the topgear.submission.received bus event for a failed processing attempt.

Root cause

The review submission table only exposed download and copy controls. The existing bus API reprocess contract was only used outside the review app.

What was changed

Added a review-app reprocess service that builds the topgear.submission.received bus payload and posts it to the V5 bus events endpoint.

Added an admin-only refresh icon next to the submission ID copy button for Topgear Task challenges.

The action sends the selected submission ID, challenge ID, URL, member handle, member ID, and submitted date.

Any added/updated tests

Added submission-reprocess.service.spec.ts to cover Topgear/admin gating, payload construction, required URL validation, and the bus API request envelope.
What was broken
The My Active Challenges table did not show submission counts, and support had no visual indicator for Topgear Task challenges with submissions where Iterative Review had not opened.

Root cause (if identifiable)
The review app model and table only used the current active-review assignment fields, so it ignored submission totals and Iterative Review phase state from the backend.

What was changed
Threaded submission count and Iterative Review state through the active review models, added a Submissions column, and highlighted affected Topgear Task rows with a faint red background and red border on desktop and mobile tables.

Any added/updated tests
Added active review assignment transformation coverage for the Topgear Task issue condition.
…ovals-list

PM-5065 - restrict access for TM/PM
PM-5059: Highlight Topgear active review issues
PM-5060: Add Topgear submission reprocess action
PM-5043: Use consumed challenge member subtotals
@kkartunov kkartunov requested a review from jmgasper as a code owner May 19, 2026 06:07
@kkartunov kkartunov changed the title [PROD RELEASE] - May [PROD RELEASE] - Updates & Fixes May 19, 2026
@kkartunov kkartunov merged commit 8a268c5 into master May 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants