Merge branch 'main' into fix-termination

Author: tnagler

.github/workflows/R-CMD-check.yaml

@@ -20,17 +20,17 @@ jobs:
         config:
           - {os: macOS-latest,   r: 'release'}
           - {os: windows-latest, r: 'release'}
-          - {os: ubuntu-20.04,   r: 'devel', rspm: "https://packagemanager.rstudio.com/cran/__linux__/focal/latest", http-user-agent: "R/4.0.0 (ubuntu-16.04) R (4.0.0 x86_64-pc-linux-gnu x86_64 linux-gnu) on GitHub Actions" }
-          - {os: ubuntu-20.04,   r: 'release', rspm: "https://packagemanager.rstudio.com/cran/__linux__/focal/latest"}
-          - {os: ubuntu-20.04,   r: 'oldrel',  rspm: "https://packagemanager.rstudio.com/cran/__linux__/focal/latest"}
+          - {os: ubuntu-latest,   r: 'devel', rspm: "https://packagemanager.rstudio.com/cran/__linux__/jammy/latest", http-user-agent: "R/devel (ubuntu-122.04) on GitHub Actions" }
+          - {os: ubuntu-latest,   r: 'release', rspm: "https://packagemanager.rstudio.com/cran/__linux__/jammy/latest"}
+          - {os: ubuntu-latest,   r: 'oldrel',  rspm: "https://packagemanager.rstudio.com/cran/__linux__/jammy/latest"}
 
     env:
       R_REMOTES_NO_ERRORS_FROM_WARNINGS: true
       RSPM: ${{ matrix.config.rspm }}
       GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v5
 
       - uses: r-lib/actions/setup-r@v2
         with:
@@ -48,7 +48,7 @@ jobs:
 
       - name: Cache R packages
         if: runner.os != 'Windows'
-        uses: actions/cache@v1
+        uses: actions/cache@v5
         with:
           path: ${{ env.R_LIBS_USER }}
           key: ${{ runner.os }}-${{ hashFiles('.github/R-version') }}-1-${{ hashFiles('.github/depends.Rds') }}
@@ -57,10 +57,11 @@ jobs:
       - name: Install system dependencies
         if: runner.os == 'Linux'
         run: |
+          sudo apt install libcurl4-openssl-dev
           while read -r cmd
           do
             eval sudo $cmd
-          done < <(Rscript -e 'writeLines(remotes::system_requirements("ubuntu", "16.04"))')
+          done < <(Rscript -e 'writeLines(remotes::system_requirements("ubuntu", "22.04"))')
 
       - name: Install dependencies
         run: |

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: RcppThread
 Title: R-Friendly Threading in C++
-Version: 2.2.0
+Version: 2.2.0.9000
 Authors@R: c(
     person("Thomas", "Nagler",, "mail@tnagler.com", role = c("aut", "cre"),
            comment = c(ORCID = "0000-0003-1855-0046"))
@@ -12,7 +12,7 @@ License: MIT + file LICENSE
 Encoding: UTF-8
 URL: https://github.com/tnagler/RcppThread
 BugReports: https://github.com/tnagler/RcppThread/issues
-RoxygenNote: 7.3.2.9000
+RoxygenNote: 7.3.3
 Suggests: 
     testthat,
     R.rsp,

NEWS.md

@@ -1,3 +1,5 @@
+# RcppThread (development version)
+
 # RcppThread 2.2.0
 
 NEW FEATURE

cran-comments.md

@@ -1,14 +1,14 @@
-Also includes a fix for the @doctype isseu (now documenting "_PACKAGE" instead of NULL).
-
 ## Test environments
 
-* ubuntu 22.04 (devel, release, old-rel)
-* macOS X (release)
-* Windows Server 2019 (release)
+* ubuntu 20.04 (devel, release, old-rel)
+* macOS 14.7.2 (release)
+* Windows Server 2022 (release)
 * CRAN win builder (devel)
 
 ## Check status summary
 
-                  NOTE OK
-  Source packages    0  1
-  Reverse depends   19  3
+We checked 19 reverse dependencies (1 from CRAN + 18 from Bioconductor), 
+comparing R CMD check results across CRAN and dev versions of this package.
+
+ * We saw 0 new problems
+ * We failed to check 0 packages

inst/include/RcppThread/Progress.hpp

@@ -30,6 +30,9 @@ class ProgressPrinter {
         , startTime_(std::chrono::steady_clock::now())
     {}
 
+    // Add virtual destructor
+    virtual ~ProgressPrinter() = default;
+
     //! prints progress whenever an update is necessary.
     virtual void printProgress() = 0;