refactor: extract strategy constants to fix goconst lint

Author: JonCanning

internal/config/config.go

@@ -11,6 +11,12 @@ import (
 	"gopkg.in/yaml.v3"
 )
 
+// StrategyCommit pushes directly to the default branch.
+const StrategyCommit = "commit"
+
+// StrategyPR creates a branch and opens a pull request.
+const StrategyPR = "pr"
+
 // CLIConfig holds all CLI-level configuration.
 type CLIConfig struct {
 	Org        string
@@ -43,7 +49,7 @@ var issueConfigRe = regexp.MustCompile(`(?s)<!--\s*issuebot\s*\n(.*?)\n-->`)
 func DefaultCLIConfig() CLIConfig {
 	return CLIConfig{
 		Label:      "",
-		Strategy:   "commit",
+		Strategy:   StrategyCommit,
 		Interval:   30 * time.Second,
 		Workers:    5,
 		MaxRetries: 3,

internal/config/config_test.go

@@ -19,8 +19,8 @@ branch: my-feature
 More text.`
 
 	cfg := ParseIssueConfig(body)
-	if cfg.Strategy != "commit" {
-		t.Errorf("strategy: got %q, want %q", cfg.Strategy, "commit")
+	if cfg.Strategy != StrategyCommit {
+		t.Errorf("strategy: got %q, want %q", cfg.Strategy, StrategyCommit)
 	}
 
 	if cfg.Branch != "my-feature" {
@@ -65,8 +65,8 @@ another: thing
 -->`
 
 	cfg := ParseIssueConfig(body)
-	if cfg.Strategy != "pr" {
-		t.Errorf("strategy: got %q, want %q", cfg.Strategy, "pr")
+	if cfg.Strategy != StrategyPR {
+		t.Errorf("strategy: got %q, want %q", cfg.Strategy, StrategyPR)
 	}
 
 	if cfg.Branch != "fix-123" {
@@ -82,7 +82,7 @@ func TestDefaultConfig(t *testing.T) {
 		got  interface{}
 		want interface{}
 	}{
-		{"strategy", cfg.Strategy, "commit"},
+		{"strategy", cfg.Strategy, StrategyCommit},
 		{"interval", cfg.Interval, 30 * time.Second},
 		{"workers", cfg.Workers, 5},
 		{"max-retries", cfg.MaxRetries, 3},
@@ -124,18 +124,18 @@ func TestDefaultConfig_WorkspaceUsesHomeDir(t *testing.T) {
 func TestResolveStrategy_IssueOverrides(t *testing.T) {
 	cli := DefaultCLIConfig()
 
-	issue := IssueConfig{Strategy: "commit"}
-	if got := ResolveStrategy(cli, issue); got != "commit" {
-		t.Errorf("got %q, want %q", got, "commit")
+	issue := IssueConfig{Strategy: StrategyCommit}
+	if got := ResolveStrategy(cli, issue); got != StrategyCommit {
+		t.Errorf("got %q, want %q", got, StrategyCommit)
 	}
 }
 
 func TestResolveStrategy_FallbackToCLI(t *testing.T) {
 	cli := DefaultCLIConfig()
 
 	issue := IssueConfig{}
-	if got := ResolveStrategy(cli, issue); got != "commit" {
-		t.Errorf("got %q, want %q", got, "commit")
+	if got := ResolveStrategy(cli, issue); got != StrategyCommit {
+		t.Errorf("got %q, want %q", got, StrategyCommit)
 	}
 }
 

internal/worker/worker.go

@@ -153,7 +153,7 @@ func (w *Worker) ProcessIssue(ctx context.Context, repo string, issue *github.Is
 	}
 
 	// If PR strategy, create branch.
-	if strategy == "pr" {
+	if strategy == config.StrategyPR {
 		cmd := exec.CommandContext(ctx, "git", "-C", repoDir, "checkout", "-b", branch)
 
 		cmd.Stderr = os.Stderr
@@ -205,7 +205,7 @@ func (w *Worker) ProcessIssue(ctx context.Context, repo string, issue *github.Is
 	}
 
 	// Push and optionally create PR.
-	if strategy == "pr" {
+	if strategy == config.StrategyPR {
 		if err := w.pushAndCreatePR(ctx, key, logger, repoDir, repo, branch, issue, attempts, issueCfg); err != nil {
 			return
 		}

internal/worker/worker_test.go

@@ -91,7 +91,7 @@ func testWorker(t *testing.T) *Worker {
 	return &Worker{
 		State:     st,
 		Notifier:  notify.New(""),
-		CLIConfig: config.CLIConfig{Strategy: "pr", MaxRetries: 3, Workspace: filepath.Join(dir, "repos"), PromptFile: promptFile, Command: testEchoCmd},
+		CLIConfig: config.CLIConfig{Strategy: config.StrategyPR, MaxRetries: 3, Workspace: filepath.Join(dir, "repos"), PromptFile: promptFile, Command: testEchoCmd},
 	}
 }
 
@@ -251,7 +251,7 @@ func TestWorker_ProcessIssue_PRStrategy(t *testing.T) {
 		Client:    ghClient,
 		State:     st,
 		Notifier:  notify.New(""),
-		CLIConfig: config.CLIConfig{Strategy: "pr", MaxRetries: 3, Workspace: filepath.Join(dir, "repos"), PromptFile: promptFile, Command: cmdPath},
+		CLIConfig: config.CLIConfig{Strategy: config.StrategyPR, MaxRetries: 3, Workspace: filepath.Join(dir, "repos"), PromptFile: promptFile, Command: cmdPath},
 
 		CloneURL: bare,
 	}
@@ -294,7 +294,7 @@ func TestWorker_ProcessIssue_DryRun(t *testing.T) {
 	w := &Worker{
 		State:     st,
 		Notifier:  notify.New(""),
-		CLIConfig: config.CLIConfig{Strategy: "pr", MaxRetries: 3, Workspace: filepath.Join(dir, "repos"), PromptFile: promptFile, DryRun: true, Command: cmdPath},
+		CLIConfig: config.CLIConfig{Strategy: config.StrategyPR, MaxRetries: 3, Workspace: filepath.Join(dir, "repos"), PromptFile: promptFile, DryRun: true, Command: cmdPath},
 
 		CloneURL: bare,
 	}
@@ -370,7 +370,7 @@ func TestWorker_ProcessIssue_PostCommand(t *testing.T) {
 		Client:    ghClient,
 		State:     st,
 		Notifier:  notify.New(""),
-		CLIConfig: config.CLIConfig{Strategy: "pr", MaxRetries: 3, Workspace: filepath.Join(dir, "repos"), PromptFile: promptFile, Command: cmdPath},
+		CLIConfig: config.CLIConfig{Strategy: config.StrategyPR, MaxRetries: 3, Workspace: filepath.Join(dir, "repos"), PromptFile: promptFile, Command: cmdPath},
 
 		CloneURL: bare,
 	}
@@ -401,8 +401,8 @@ func TestWorker_ProcessIssue_IssueConfigOverride(t *testing.T) {
 	issueCfg := config.ParseIssueConfig(body)
 
 	strategy := config.ResolveStrategy(cli, issueCfg)
-	if strategy != "pr" {
-		t.Errorf("strategy = %q, want %q", strategy, "pr")
+	if strategy != config.StrategyPR {
+		t.Errorf("strategy = %q, want %q", strategy, config.StrategyPR)
 	}
 
 	branch := config.ResolveBranch(issueCfg, 5)