Use HTTP Post when retrieving result (#41)

* Use http post when retrieving result

* 1.6.4 and changelog

* When commands is empty, do a get with body null

* Change condition to use empty

* fix: correct HTTP method logic for Source result requests

- Fix inverted boolean logic for has_commands check
- Ensure GET is used when no commands are present
- Ensure POST is used when commands are present
- Add comprehensive tests for both GET and POST scenarios

Author: tijmenbruggeman

CHANGES.md

@@ -1,3 +1,6 @@
+## 1.6.4
+* Will use POST instead of GET when retrieving result.
+
 ## 1.6.3
 * Add minimum TLS 1.2 version to curl options as protocol negotiation on certain openssl/libcurl versions is flaky.
 

lib/Tinify/Source.php

@@ -53,7 +53,10 @@ public function transform($options) {
     }
 
     public function result() {
-        $response = Tinify::getClient()->request("get", $this->url, $this->commands);
+        $has_commands  = !empty($this->commands);
+        $method = $has_commands ? "post" : "get";
+        $body = $has_commands ? $this->commands : null;
+        $response = Tinify::getClient()->request($method, $this->url, $body);
         return new Result($response->headers, $response->body);
     }
 

test/TinifySourceTest.php

@@ -132,6 +132,31 @@ public function testResultShouldReturnResult() {
         ));
 
         $this->assertInstanceOf("Tinify\Result", Tinify\Source::fromBuffer("png file")->result());
+        $this->assertSame("GET", CurlMock::last(CURLOPT_CUSTOMREQUEST));
+    }
+
+    /**
+     * When request does not contain commands, it should use method GET
+     * when it contains commands, it should have a body and method POST
+     */
+    public function testResultWithCommandsShouldReturnResultUsingPost() {
+        Tinify\setKey("valid");
+
+        CurlMock::register("https://api.tinify.com/shrink", array(
+            "status" => 201,
+            "headers" => array("Location" => "https://api.tinify.com/some/location"),
+        ));
+
+        CurlMock::register("https://api.tinify.com/some/location", array(
+            "status" => 200, "body" => "resized file"
+        ));
+
+        $source = Tinify\Source::fromBuffer("png file")->resize(array("width" => 400));
+        $result = $source->result();
+
+        $this->assertInstanceOf("Tinify\Result", $result);
+        $this->assertSame("POST", CurlMock::last(CURLOPT_CUSTOMREQUEST));
+        $this->assertSame('{"resize":{"width":400}}', CurlMock::last(CURLOPT_POSTFIELDS));
     }
 
     public function testPreserveShouldReturnSource() {
@@ -162,6 +187,7 @@ public function testPreserveShouldReturnSourceWithData() {
 
         $this->assertSame("copyrighted file", Tinify\Source::fromBuffer("png file")->preserve("copyright", "location")->toBuffer());
         $this->assertSame("{\"preserve\":[\"copyright\",\"location\"]}", CurlMock::last(CURLOPT_POSTFIELDS));
+        $this->assertSame("POST", CurlMock::last(CURLOPT_CUSTOMREQUEST));
     }
 
     public function testPreserveShouldReturnSourceWithDataForArray() {