fix: removed GET with body from result() call and replaced with POST to prepare for deprecation of GET with body from API.

Author: Eirini

CHANGES.md

@@ -1,5 +1,7 @@
-## 1.8.1
+## 1.8.2
+* Removed the `GET` with body HTTP call that was being made when obtaining the results of a compression and transforming at the same time. Replaced with `POST` in order to prepare for deprecation of `GET` with body interface from API.
 
+## 1.8.1
 * Set minimum node engine to v14 in package.json
 * Update examples in README
 * Test the code on node 24

package.json

@@ -1,6 +1,6 @@
 {
   "name": "tinify",
-  "version": "1.8.1",
+  "version": "1.8.2",
   "description": "Node.js client for the Tinify API. Tinify compresses your images intelligently. Read more at https://tinify.com.",
   "keywords": [
     "tinify",
@@ -54,4 +54,4 @@
     "tslint": "^5.10.0",
     "typescript": "^5.7.3"
   }
-}
+}

src/tinify/Source.ts

@@ -77,7 +77,11 @@ export default class Source {
   result(): Result {
     const commands = this._commands
     const response = this._url.then(url => {
-      return tinify.client.request("get", url, commands)
+      if(Object.keys(commands).length === 0){
+        return tinify.client.request("get", url)
+      } else {
+        return tinify.client.request("post", url, commands)
+      }
     })
 
     return new tinify.Result(

test/tinify-source-test.js

@@ -62,7 +62,7 @@ describe("Source", function() {
 
       it("should return source with data", function() {
         nock("https://api.tinify.com")
-          .get("/some/location")
+          .post("/some/location")
           .reply(200, "compressed file")
 
         const data = tinify.Source.fromFile(dummyFile).toBuffer()
@@ -86,7 +86,7 @@ describe("Source", function() {
 
       it("should return source with data", function() {
         nock("https://api.tinify.com")
-          .get("/some/location")
+          .post("/some/location")
           .reply(200, "compressed file")
 
         const data = tinify.Source.fromBuffer("png file").toBuffer()
@@ -112,7 +112,7 @@ describe("Source", function() {
           .reply(201, {}, {location: "https://api.tinify.com/some/location"})
 
         nock("https://api.tinify.com")
-          .get("/some/location")
+          .post("/some/location")
           .reply(200, "compressed file")
 
         const data = tinify.Source.fromUrl("http://example.com/test.jpg").toBuffer()
@@ -139,7 +139,7 @@ describe("Source", function() {
           .reply(201, {}, {location: "https://api.tinify.com/some/location"})
 
         nock("https://api.tinify.com")
-          .get("/some/location")
+          .post("/some/location")
           .reply(200, "compressed file")
       })
 
@@ -156,7 +156,7 @@ describe("Source", function() {
           .reply(201, {}, {location: "https://api.tinify.com/some/location"})
 
         nock("https://api.tinify.com")
-          .get("/some/location", '{"preserve":["copyright","location"]}')
+          .post("/some/location", '{"preserve":["copyright","location"]}')
           .reply(200, "copyrighted file")
       })
 
@@ -181,7 +181,7 @@ describe("Source", function() {
 
       it("should include other options if set", function() {
         nock("https://api.tinify.com")
-          .get("/some/location", '{"preserve":["copyright","location"],"resize":{"width":400}}')
+          .post("/some/location", '{"preserve":["copyright","location"],"resize":{"width":400}}')
           .reply(200, "copyrighted resized file")
 
         const data = tinify.Source.fromBuffer("png file").resize({width: 400}).preserve("copyright", "location").toBuffer()
@@ -198,7 +198,7 @@ describe("Source", function() {
           .reply(201, {}, {location: "https://api.tinify.com/some/location"})
 
         nock("https://api.tinify.com")
-          .get("/some/location", '{"resize":{"width":400}}')
+          .post("/some/location", '{"resize":{"width":400}}')
           .reply(200, "small file")
       })
 
@@ -257,7 +257,7 @@ describe("Source", function() {
           .reply(201, {}, {location: "https://api.tinify.com/some/location"})
 
         nock("https://api.tinify.com")
-          .get("/some/location")
+          .post("/some/location")
           .reply(200, "compressed file")
       })
 
@@ -276,7 +276,7 @@ describe("Source", function() {
           .reply(201, {}, {location: "https://api.tinify.com/some/location"})
 
         nock("https://api.tinify.com")
-          .get("/some/location")
+          .post("/some/location")
           .reply(200, "compressed file")
       })
 

test/tinify-test.js

@@ -192,7 +192,7 @@ describe("tinify", function() {
         .reply(201, {}, {Location: "https://api.tinify.com/some/location"})
 
       nock("https://api.tinify.com")
-        .get("/some/location")
+        .post("/some/location")
         .reply(200, "compressed file")
     })
 
@@ -215,7 +215,7 @@ describe("tinify", function() {
         .reply(201, {}, {Location: "https://api.tinify.com/some/location"})
 
       nock("https://api.tinify.com")
-        .get("/some/location")
+        .post("/some/location")
         .reply(200, "compressed file")
     })
 
@@ -238,7 +238,7 @@ describe("tinify", function() {
         .reply(201, {}, {Location: "https://api.tinify.com/some/location"})
 
       nock("https://api.tinify.com")
-        .get("/some/location")
+        .post("/some/location")
         .reply(200, "compressed file")
     })