Skip to content

Commit 8d251b5

Browse files
musmannnjacobtylerwalls
authored andcommitted
Fixed #36920 -- Fixed alignment of fieldset legends in wide admin forms.
Visual regression in 4187da2.
1 parent cb24beb commit 8d251b5

5 files changed

Lines changed: 18 additions & 2 deletions

File tree

AUTHORS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -775,6 +775,7 @@ answer newbie questions, and generally made Django that much better:
775775
Mridul Dhall <mriduldhall1@gmail.com>
776776
msaelices <msaelices@gmail.com>
777777
msundstr
778+
Muhammad Usman <muhammad.usman11914@gmail.com>
778779
Mushtaq Ali <mushtaak@gmail.com>
779780
Mykola Zamkovoi <nickzam@gmail.com>
780781
Nadège Michel <michel.nadege@gmail.com>

django/contrib/admin/static/admin/css/forms.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,8 @@ fieldset .fieldBox {
218218

219219
/* WIDE FIELDSETS */
220220

221-
.wide label {
221+
.wide label,
222+
.wide legend {
222223
width: 200px;
223224
}
224225

django/contrib/admin/static/admin/css/rtl.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,8 @@ thead th.sorted .text {
124124

125125
/* FORMS */
126126

127-
.aligned label {
127+
.aligned label,
128+
.aligned legend {
128129
padding: 0 0 3px 1em;
129130
}
130131

docs/releases/6.0.3.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,6 @@ Bugfixes
1515
* Fixed :exc:`AttributeError` when subclassing builtin lookups and neglecting
1616
to :ref:`override<tuple-for-params>` ``as_sql()`` to accept any sequence
1717
(:ticket:`36934`).
18+
19+
* Fixed a visual regression where fieldset legends were misaligned in the admin
20+
(:ticket:`36920`).

tests/admin_views/test_password_form.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
from django.contrib.admin.tests import AdminSeleniumTestCase
22
from django.contrib.auth.models import User
33
from django.test import override_settings
4+
from django.test.selenium import screenshot_cases
45
from django.urls import reverse
56

67

@@ -142,3 +143,12 @@ def test_change_password_for_existing_user(self):
142143
# Only the set password submit button is visible.
143144
self.assertIs(submit_set.is_displayed(), True)
144145
self.assertIs(submit_unset.is_displayed(), False)
146+
147+
@screenshot_cases(["desktop_size", "mobile_size", "rtl", "dark", "high_contrast"])
148+
def test_fieldset_legend_wide_alignment(self):
149+
user_add_url = reverse("auth_test_admin:auth_user_add")
150+
self.admin_login(username="super", password="secret")
151+
self.selenium.get(self.live_server_url + user_add_url)
152+
153+
# The fieldset legend is aligned with other fields.
154+
self.take_screenshot("fieldset_legend_wide")

0 commit comments

Comments
 (0)