Compile to Typescript?

[goswinr]

Should Toth.Json compile with dotnet fable --lang typescript to valid typescript?
I currently get this error when invoking tsc on the result. (fable 5.0.0-alpha.4)

If this is complicated to fix, I would also be happy to use a less generic workaround like sugested in #202 in my on fork.

Background: I am trying to compile my F# to TS only, so that it integrates nicely into a larger Angular App.
My domain model runs on .NET and Browser. Yes, Fable is amazing !
And Thot.Json allows me to de- and serialize on .NET and Browser with the same code. Amazing!

[MangelMaxime]

The issue is not with Thoth.Json but with Fable compilation.

So once, we fix Fable compilation both Thoth.Json and Thoth.Json.Core should work with TypeScript.

[goswinr]

might be solved with fable-compiler/Fable#3586

[MangelMaxime]

Fable-rc.1 contains the changes from the PR linked above.

I tried to run ./build.sh test typescript but I am getting some errors from TypeScript compilation.

TBH, I am not expert in TypeScript so if someone can look at the error and see how we need to adapt the tsconfig.json it would be great.

[olivercoad]

@MangelMaxime what are the errors you are getting?

When I run that, most of the errors I get look the same as the problem with generics from that issue. The PR only fixes the Reflection functions, it does not fix the generics issues like

fableBuild/packages/Thoth.Json.Core/Encode.ts:241:66 - error TS2304: Cannot find name '$a'.

241             Encode<JsonValue>(helpers_1: IEncoderHelpers$1<$a>): $a {

---

Are there any tests for Thoth.Json? It's the package which has the reflection functions that should be fixed in RC-1, but I can't see it in tests/Thoth.Json.Tests.JavaScript/fableBuild/packages (only Thoth.Json.Core and Thoth.Json.JavaScript).

[MangelMaxime]

Hello @olivercoad,

Thoth.Json tests are located under https://github.com/thoth-org/Thoth.Json/tree/main/tests/Thoth.Json.Tests.Legacy

[olivercoad]

Thanks, that helps. I didn't know Auto coders were legacy.
What's the reason Thoth.Json is in it's own test folder and only tested with javascript, instead of being covered by the shared test project used by Javascript/Typescript/Python/Newtonsoft/SystemTextJson ?

[MangelMaxime]

This is because Thoth.Json is not using the same API as the others packages.

Because of that they can't be written using the shared Thoth.Json.Core decoders and would requires having compiler directives all over the place.

The goal is for Thoth.Json to be deprecated in favor of Thoth.Json.Core once I merge the Auto API in it. By using, Thoth.Json.Core people can share backend and front end code more easily without having to rely on compiler directives, and don't need to include backend / frontend only packages in their projects.