Merge branch 'main' into drain-param

Author: bytenik

.github/workflows/ci.yml

@@ -22,7 +22,7 @@ jobs:
         node-version:
           - 18
           - 20
-          - 22
+          - 22.17.1 # experimental TS type striping in 22.18.0 breaks the build
 
     services:
       redis:
@@ -35,6 +35,18 @@ jobs:
         ports:
           - 6379:6379
 
+      postgres:
+        image: postgres:14
+        env:
+          POSTGRES_PASSWORD: changeit
+        options: >-
+          --health-cmd pg_isready
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
+        ports:
+          - 5432:5432
+
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4

docs/engine.io-protocol/v4-test-suite/test-suite.js

@@ -332,6 +332,25 @@ describe("Engine.IO protocol", () => {
 
         expect(pollResponse.status).to.eql(400);
       });
+
+      it("closes the session upon cancelled polling request", async () => {
+        const sid = await initLongPollingSession();
+        const controller = new AbortController();
+
+        fetch(`${URL}/engine.io/?EIO=4&transport=polling&sid=${sid}`, {
+          signal: controller.signal,
+        }).catch(() => {});
+
+        await sleep(5);
+
+        controller.abort();
+
+        const pollResponse = await fetch(
+          `${URL}/engine.io/?EIO=4&transport=polling&sid=${sid}`,
+        );
+
+        expect(pollResponse.status).to.eql(400);
+      });
     });
 
     describe("WebSocket", () => {