Suppress debug output during test runs (#501)

* Suppress debug output during test runs

Clean up test output by preventing debug logging from cluttering
test results while maintaining full debug functionality in production.

Changes:
- WebSocketConnection: Only call printOutput() in non-test environments
- test/shared/setup.mjs: Disable debug module by default during tests
- test/unit/core/utils.test.mjs: Properly cleanup debug state in afterEach
- test/unit/core/utils-enhanced.test.mjs: Fix test assertions and cleanup
- vitest.config.mjs: Add reporter configuration

Benefits:
- Clean, readable test output without debug noise
- Maintains full debug functionality in production
- Tests that specifically need debug can enable it explicitly
- All 632 tests passing with zero debug output

Before: Tests showed verbose socket events, errors, and debug messages
After: Clean test output showing only test results

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Address Gemini code review comments

Improvements based on Gemini's medium-priority feedback:

1. Centralize debug module imports:
   - test/shared/setup.mjs: Use import at top instead of require in hooks
   - test/unit/core/utils.test.mjs: Add import debug at top, reuse in hooks
   - test/unit/core/utils-enhanced.test.mjs: Add import debug at top, reuse in hooks

2. Clean up redundant configuration:
   - vitest.config.mjs: Remove redundant silent and reporters defaults

Benefits:
- Consistent ES module import style across all test files
- DRY principle - import once, reuse throughout the file
- Cleaner vitest configuration without unnecessary defaults

All 632 tests still passing with zero debug output.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude Code <claude-code@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>

Author: 3 people

lib/WebSocketConnection.js

@@ -313,7 +313,10 @@ class WebSocketConnection extends EventEmitter {
       this.emit('error', error);
     }
     this.socket.destroy();
-    this._debug.printOutput();
+    // Only print debug output in non-test environments to avoid cluttering test output
+    if (process.env.NODE_ENV !== 'test') {
+      this._debug.printOutput();
+    }
   }
 
   handleSocketEnd() {

test/shared/setup.mjs

@@ -1,23 +1,37 @@
 import { beforeEach, afterEach, vi } from 'vitest';
 import { stopAllServers } from '../helpers/test-server.mjs';
+import debug from 'debug';
 
 // Increase max listeners to avoid warnings when running many tests with child processes
 // Vitest adds exit/beforeExit listeners for each test file with spawned processes
 process.setMaxListeners(30);
 
+// Disable debug output during tests unless explicitly enabled
+if (!process.env.DEBUG) {
+  debug.disable();
+}
+
 // Global test setup for each test file
 beforeEach(() => {
   // Clear all mocks and timers
   vi.clearAllTimers();
   vi.clearAllMocks();
+
+  // Note: We don't disable debug in beforeEach as some tests need to enable it
+  // Tests that enable DEBUG should clean up properly in their own afterEach
 });
 
 afterEach(async () => {
   // Restore all mocks
   vi.restoreAllMocks();
-  
+
   // Clean up any test servers
   await stopAllServers();
+
+  // Re-disable debug after each test to prevent leakage
+  if (!process.env.DEBUG) {
+    debug.disable();
+  }
 });
 
 // Set up global test configuration

test/unit/core/utils-enhanced.test.mjs

@@ -9,6 +9,7 @@
  */
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
 import * as utils from '../../../lib/utils.js';
+import debug from 'debug';
 
 describe('Utils Module - Enhanced Coverage', () => {
   describe('BufferingLogger.printOutput() behavior', () => {
@@ -20,8 +21,12 @@ describe('Utils Module - Enhanced Coverage', () => {
     });
 
     afterEach(() => {
+      debug.disable();
       if (originalDebugEnv !== undefined) {
         process.env.DEBUG = originalDebugEnv;
+        if (originalDebugEnv) {
+          debug.enable(originalDebugEnv);
+        }
       } else {
         delete process.env.DEBUG;
       }
@@ -62,8 +67,12 @@ describe('Utils Module - Enhanced Coverage', () => {
     });
 
     afterEach(() => {
+      debug.disable();
       if (originalDebugEnv !== undefined) {
         process.env.DEBUG = originalDebugEnv;
+        if (originalDebugEnv) {
+          debug.enable(originalDebugEnv);
+        }
       } else {
         delete process.env.DEBUG;
       }
@@ -81,9 +90,12 @@ describe('Utils Module - Enhanced Coverage', () => {
 
         expect(mockLog).toHaveBeenCalled();
         // Verify the format includes timestamp and uniqueID
+        // printOutput calls logFunction.apply(global, args) where args includes:
+        // [formatString, date, uniqueID, ...originalArgs]
         const firstCall = mockLog.mock.calls[0];
         expect(firstCall).toBeDefined();
-        expect(firstCall[0]).toContain('test-id');
+        // The uniqueID should be in args[2] (after formatString and date)
+        expect(firstCall[2]).toBe('test-id');
       }
     });
 

test/unit/core/utils.test.mjs

@@ -11,6 +11,7 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
 import { EventEmitter } from 'events';
 import * as utils from '../../../lib/utils.js';
+import debug from 'debug';
 
 describe('Utils Module', () => {
   describe('noop()', () => {
@@ -251,8 +252,12 @@ describe('Utils Module', () => {
     });
 
     afterEach(() => {
+      debug.disable();
       if (originalDebugEnv !== undefined) {
         process.env.DEBUG = originalDebugEnv;
+        if (originalDebugEnv) {
+          debug.enable(originalDebugEnv);
+        }
       } else {
         delete process.env.DEBUG;
       }