Skip to content

Commit 61627a8

Browse files
committed
library-manager: disable INTEL_MODULES by default
IADK is rarely needed, but when enabled it adds C++ objects to the build, while otherwise build are pure C. Disable INTEL_MODULES by default on ACE platforms. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
1 parent 68b51b4 commit 61627a8

6 files changed

Lines changed: 8 additions & 19 deletions

File tree

app/boards/intel_adsp_ace15_mtpm.conf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ CONFIG_ZEPHYR_TWB_SCHEDULER=y
5252
CONFIG_COLD_STORE_EXECUTE_DRAM=y
5353

5454
# SOF / loadable modules
55-
CONFIG_INTEL_MODULES=y
5655
CONFIG_LIBRARY_MANAGER=y
5756
CONFIG_LIBRARY_AUTH_SUPPORT=y
5857
CONFIG_LIBRARY_BASE_ADDRESS=0xa0688000

app/boards/intel_adsp_ace20_lnl.conf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ CONFIG_ZEPHYR_DP_SCHEDULER=y
3838
CONFIG_ZEPHYR_NATIVE_DRIVERS=y
3939

4040
# SOF / loadable modules
41-
CONFIG_INTEL_MODULES=y
4241
CONFIG_LIBRARY_AUTH_SUPPORT=y
4342
CONFIG_LIBRARY_BASE_ADDRESS=0xa0688000
4443
CONFIG_LIBRARY_MANAGER=y

app/boards/intel_adsp_ace30_ptl.conf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ CONFIG_ZEPHYR_DP_SCHEDULER=y
3737
CONFIG_ZEPHYR_NATIVE_DRIVERS=y
3838

3939
# SOF / loadable modules
40-
CONFIG_INTEL_MODULES=y
4140
CONFIG_LIBRARY_MANAGER=y
4241
CONFIG_LIBRARY_BASE_ADDRESS=0xa0688000
4342
CONFIG_LIBRARY_BUILD_LIB=y

src/include/sof/audio/module_adapter/library/native_system_service.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
#define NATIVE_SYSTEM_SERVICE_H
88

99
#include <stdint.h>
10-
#include <adsp_stddef.h>
1110

1211
#ifdef __cplusplus
1312
extern "C" {

src/library_manager/lib_manager.c

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -485,7 +485,6 @@ const struct sof_man_module *lib_manager_get_module_manifest(const uint32_t modu
485485
SOF_MAN_MODULE_OFFSET(entry_index));
486486
}
487487

488-
#if CONFIG_INTEL_MODULES
489488
/*
490489
* \brief Load module code, allocate its instance and create a module adapter component.
491490
* \param[in] drv - component driver pointer.
@@ -584,7 +583,9 @@ static void lib_manager_prepare_module_adapter(struct comp_driver *drv, const st
584583
drv->ops.dai_ts_start = module_adapter_ts_start_op;
585584
drv->ops.dai_ts_stop = module_adapter_ts_stop_op;
586585
drv->ops.dai_ts_get = module_adapter_ts_get_op;
586+
#if CONFIG_INTEL_MODULES
587587
drv->adapter_ops = &processing_module_adapter_interface;
588+
#endif
588589
}
589590

590591
int lib_manager_register_module(const uint32_t component_id)
@@ -679,14 +680,6 @@ int lib_manager_register_module(const uint32_t component_id)
679680
return ret;
680681
}
681682

682-
#else /* CONFIG_INTEL_MODULES */
683-
int lib_manager_register_module(const uint32_t component_id)
684-
{
685-
tr_err(&lib_manager_tr, "Dynamic module loading is not supported");
686-
return -ENOTSUP;
687-
}
688-
#endif /* CONFIG_INTEL_MODULES */
689-
690683
static int lib_manager_dma_buffer_alloc(struct lib_manager_dma_ext *dma_ext,
691684
uint32_t size)
692685
{

zephyr/CMakeLists.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -520,9 +520,15 @@ zephyr_library_sources_ifdef(CONFIG_COMP_MODULE_ADAPTER
520520
${SOF_AUDIO_PATH}/module_adapter/module/generic.c
521521
)
522522

523+
zephyr_include_directories_ifdef(CONFIG_LIBRARY_MANAGER
524+
${SOF_SRC_PATH}/include/sof/audio/module_adapter/library/
525+
${SOF_SRC_PATH}/include/sof/audio/module_adapter/iadk/
526+
)
527+
523528
zephyr_library_sources_ifdef(CONFIG_LIBRARY_MANAGER
524529
${SOF_SRC_PATH}/library_manager/lib_manager.c
525530
${SOF_SRC_PATH}/library_manager/lib_notification.c
531+
${SOF_AUDIO_PATH}/module_adapter/library/native_system_agent.c
526532
)
527533

528534
if (CONFIG_MM_DRV AND CONFIG_LLEXT)
@@ -531,17 +537,11 @@ zephyr_library_sources_ifdef(CONFIG_LIBRARY_MANAGER
531537
)
532538
endif()
533539

534-
zephyr_include_directories_ifdef(CONFIG_INTEL_MODULES
535-
${SOF_SRC_PATH}/include/sof/audio/module_adapter/iadk/
536-
${SOF_SRC_PATH}/include/sof/audio/module_adapter/library/
537-
)
538-
539540
zephyr_library_sources_ifdef(CONFIG_INTEL_MODULES
540541
${SOF_AUDIO_PATH}/module_adapter/module/modules.c
541542
${SOF_AUDIO_PATH}/module_adapter/iadk/module_initial_settings_concrete.cpp
542543
${SOF_AUDIO_PATH}/module_adapter/iadk/iadk_module_adapter.cpp
543544
${SOF_AUDIO_PATH}/module_adapter/iadk/system_agent.cpp
544-
${SOF_AUDIO_PATH}/module_adapter/library/native_system_agent.c
545545
${SOF_AUDIO_PATH}/module_adapter/library/native_system_service.c
546546
)
547547

0 commit comments

Comments
 (0)