Skip to content

Commit 9598f4e

Browse files
committed
ASoC: SOF: reduce default verbosity of IPC logs
We currently log the initiation of an IPC as well at its success. [ 3906.106987] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: ipc tx: 0x80010000: GLB_DAI_MSG: CONFIG [ 3906.107189] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: ipc tx succeeded: 0x80010000: GLB_DAI_MSG: CONFIG This is overkill in most cases, we already have a message thrown in case of errors and have tracepoints enabled to check for IPC duration. The only case where this might be useful is to check if there is an interleaved IPC RX. Add a flag and only print those logs if enabled. In addition, the DMA_POSITION_UPDATE for traces brings limited information in most cases and pollutes the logs for no good reason. [ 3906.322256] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: ipc rx: 0x90020000: GLB_TRACE_MSG: DMA_POSITION [ 3906.322308] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: ipc rx done: 0x90020000: GLB_TRACE_MSG: DMA_POSITION [ 3906.822261] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: ipc rx: 0x90020000: GLB_TRACE_MSG: DMA_POSITION [ 3906.822319] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: ipc rx done: 0x90020000: GLB_TRACE_MSG: DMA_POSITION [ 3907.822261] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: ipc rx: 0x90020000: GLB_TRACE_MSG: DMA_POSITION [ 3907.822319] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: ipc rx done: 0x90020000: GLB_TRACE_MSG: DMA_POSITION [ 3908.822251] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: ipc rx: 0x90020000: GLB_TRACE_MSG: DMA_POSITION [ 3908.822309] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: ipc rx done: 0x90020000: GLB_TRACE_MSG: DMA_POSITION This information is only helpful when debugging the trace support, not when using the trace. Add a flag to only print DMA position update logs if enabled. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
1 parent f6ee233 commit 9598f4e

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

sound/soc/sof/ipc3.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,8 @@ static void ipc3_log_header(struct device *dev, u8 *text, u32 cmd)
148148
case SOF_IPC_TRACE_DMA_PARAMS:
149149
str2 = "DMA_PARAMS"; break;
150150
case SOF_IPC_TRACE_DMA_POSITION:
151+
if (!sof_debug_check_flag(SOF_DBG_PRINT_DMA_POSITION_UPDATE_LOGS))
152+
return;
151153
str2 = "DMA_POSITION"; break;
152154
case SOF_IPC_TRACE_DMA_PARAMS_EXT:
153155
str2 = "DMA_PARAMS_EXT"; break;
@@ -300,7 +302,8 @@ static int ipc3_wait_tx_done(struct snd_sof_ipc *ipc, void *reply_data)
300302
"ipc tx error for %#x (msg/reply size: %d/%zu): %d\n",
301303
hdr->cmd, hdr->size, msg->reply_size, ret);
302304
} else {
303-
ipc3_log_header(sdev->dev, "ipc tx succeeded", hdr->cmd);
305+
if (sof_debug_check_flag(SOF_DBG_PRINT_IPC_SUCCESS_LOGS))
306+
ipc3_log_header(sdev->dev, "ipc tx succeeded", hdr->cmd);
304307
if (msg->reply_size)
305308
/* copy the data returned from DSP */
306309
memcpy(reply_data, msg->reply_data,

sound/soc/sof/sof-priv.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,12 @@
3737
#define SOF_DBG_IGNORE_D3_PERSISTENT BIT(7) /* ignore the DSP D3 persistent capability
3838
* and always download firmware upon D3 exit
3939
*/
40+
#define SOF_DBG_PRINT_DMA_POSITION_UPDATE_LOGS BIT(8) /* print DMA position updates
41+
* in dmesg logs
42+
*/
43+
#define SOF_DBG_PRINT_IPC_SUCCESS_LOGS BIT(9) /* print IPC success
44+
* in dmesg logs
45+
*/
4046

4147
/* Flag definitions used for controlling the DSP dump behavior */
4248
#define SOF_DBG_DUMP_REGS BIT(0)

0 commit comments

Comments
 (0)