Skip to content

Commit f9d92a5

Browse files
committed
chore: address CodeRabbit feedback from dashpay#493
- Fix README badge URLs: dashevo → dashpay for license, CI, and lines-of-code badges (codecov badges were already correct) - Move crate_flags output after the crate loop so coverage flags are only emitted when at least one crate actually executed (prevents advertising skipped crates like dash-fuzz on Windows to Codecov)
1 parent 9959201 commit f9d92a5

2 files changed

Lines changed: 9 additions & 6 deletions

File tree

.github/scripts/ci_config.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -173,18 +173,17 @@ def run_group_tests(args):
173173

174174
crates = groups[args.group] or []
175175
failed = []
176+
executed = []
176177
coverage = getattr(args, "coverage", False)
177178
no_coverage = config.get("no_coverage", []) or []
178179

179-
if coverage and args.group not in no_coverage:
180-
github_output("crate_flags", args.group)
181-
182180
for crate in crates:
183181
# Skip dash-fuzz on Windows
184182
if args.os == "windows-latest" and crate == "dash-fuzz":
185183
github_notice(f"Skipping {crate} on Windows (honggfuzz not supported)")
186184
continue
187185

186+
executed.append(crate)
188187
github_group_start(f"Testing {crate}")
189188

190189
if coverage and args.group not in no_coverage:
@@ -199,6 +198,10 @@ def run_group_tests(args):
199198
failed.append(crate)
200199
github_error(f"Test failed for {crate} on {args.os}")
201200

201+
# Emit coverage flag only if at least one crate was actually executed
202+
if coverage and args.group not in no_coverage and executed:
203+
github_output("crate_flags", args.group)
204+
202205
if failed:
203206
print("\n" + "=" * 40)
204207
print(f"FAILED TESTS ({args.group} on {args.os}):")

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@
99

1010
<p>
1111
<a href="https://crates.io/crates/dash"><img alt="Crate Info" src="https://img.shields.io/crates/v/dash.svg"/></a>
12-
<a href="https://github.com/dashevo/rust-dashcore/blob/master/LICENSE"><img alt="MIT or Apache-2.0 Licensed" src="https://img.shields.io/badge/license-MIT%2FApache--2.0-blue.svg"/></a>
13-
<a href="https://github.com/dashevo/rust-dashcore/actions?query=workflow%3AContinuous%20integration"><img alt="CI Status" src="https://github.com/dashevo/rust-dashcore/workflows/Continuous%20integration/badge.svg"></a>
12+
<a href="https://github.com/dashpay/rust-dashcore/blob/master/LICENSE"><img alt="MIT or Apache-2.0 Licensed" src="https://img.shields.io/badge/license-MIT%2FApache--2.0-blue.svg"/></a>
13+
<a href="https://github.com/dashpay/rust-dashcore/actions?query=workflow%3AContinuous%20integration"><img alt="CI Status" src="https://github.com/dashpay/rust-dashcore/workflows/Continuous%20integration/badge.svg"></a>
1414
<a href="https://codecov.io/gh/dashpay/rust-dashcore/branch/master"><img alt="Coverage (master)" src="https://codecov.io/gh/dashpay/rust-dashcore/branch/master/graph/badge.svg"/></a>
1515
<a href="https://codecov.io/gh/dashpay/rust-dashcore/branch/v0.42-dev"><img alt="Coverage (develop)" src="https://codecov.io/gh/dashpay/rust-dashcore/branch/v0.42-dev/graph/badge.svg"/></a>
1616
<a href="https://docs.rs"><img alt="API Docs" src="https://img.shields.io/badge/docs.rs-rust--dashcore-green"/></a>
1717
<a href="#minimum-supported-rust-version-msrv"><img alt="Rustc Version 1.89+" src="https://img.shields.io/badge/rustc-1.89%2B-lightgrey.svg"/></a>
18-
<img alt="Lines of code" src="https://img.shields.io/tokei/lines/github/dashevo/rust-dashcore">
18+
<img alt="Lines of code" src="https://img.shields.io/tokei/lines/github/dashpay/rust-dashcore">
1919
</p>
2020
</div>
2121

0 commit comments

Comments
 (0)