[Bug]: Crashes

[AldebaraanMKII]

mpqcli version

0.10.2

Host OS

Windows

Installation method

Prebuilt binary

mpqcli command

& $MpqCliPath create --game wow-wotlk $MPQFolderPath --output $MPQDestPath

Expected behaviour

That it created the MPQ

Actual behaviour / error output

Crash. Check crash dumps.

Additional context

mpqcli-windows-amd64.exe.5820.dmp
mpqcli-windows-amd64.exe.12744.dmp
mpqcli-windows-amd64.exe.13232.dmp
mpqcli-windows-amd64.exe.14148.dmp
mpqcli-windows-amd64.exe.17224.dmp
mpqcli-windows-amd64.exe.19120.dmp
mpqcli-windows-amd64.exe.20164.dmp
mpqcli-windows-amd64.exe.20352.dmp
mpqcli-windows-amd64.exe.20432.dmp
mpqcli-windows-amd64.exe.20716.dmp

[AldebaraanMKII]

More info:
The folder ($MPQFolderPath = L:\MPQs\Data) looks like this:

L:\MPQs\Data\character
L:\MPQs\Data\interface
L:\MPQs\Data\Item
L:\MPQs\Data\M
L:\MPQs\Data\Textures
L:\MPQs\Data\world

[thomaslaurenson]

Thanks for providing the crash dump files - made it possible to review the problem and try figure out what was happening. Pretty sure the issue is that when adding files, I use fs::relative() to compare the absolute path of the file on disk, to a relative path which should be added to the MPQ (so that we keep folder structure in the MPQ). The relative() function works fine on NTFS volumes, but can have issues. In your system, what is the L: drive, is it a network share, subst mapped folder, or RAM disk? Or some other storage that is not a normal NTFS volume? If so, I am pretty sure this is the problem and I can fix.

[thomaslaurenson]

For future me...

Below seems to be the most reasonable solution which does not rely on the underlying OS, and does a pure string-based comparison:

fs::path input_file_path = entry.path().lexically_relative(target_path);