fix: handle undefined instance in sendMessage controller with proper 404

Author: Hamza Shahid

src/api/controllers/sendMessage.controller.ts

@@ -15,7 +15,7 @@ import {
   SendTextDto,
 } from '@api/dto/sendMessage.dto';
 import { WAMonitoringService } from '@api/services/monitor.service';
-import { BadRequestException } from '@exceptions';
+import { BadRequestException, NotFoundException } from '@exceptions';
 import { isBase64, isURL } from 'class-validator';
 import emojiRegex from 'emoji-regex';
 
@@ -31,12 +31,22 @@ function isEmoji(str: string) {
 export class SendMessageController {
   constructor(private readonly waMonitor: WAMonitoringService) {}
 
+  private getInstance(instanceName: string) {
+    const instance = this.waMonitor.waInstances[instanceName];
+    if (!instance) {
+      throw new NotFoundException(
+        `Instance "${instanceName}" not found or not connected. Please connect the instance first.`,
+      );
+    }
+    return instance;
+  }
+
   public async sendTemplate({ instanceName }: InstanceDto, data: SendTemplateDto) {
-    return await this.waMonitor.waInstances[instanceName].templateMessage(data);
+    return await this.getInstance(instanceName).templateMessage(data);
   }
 
   public async sendText({ instanceName }: InstanceDto, data: SendTextDto) {
-    return await this.waMonitor.waInstances[instanceName].textMessage(data);
+    return await this.getInstance(instanceName).textMessage(data);
   }
 
   public async sendMedia({ instanceName }: InstanceDto, data: SendMediaDto, file?: any) {
@@ -45,63 +55,62 @@ export class SendMessageController {
     }
 
     if (file || isURL(data?.media) || isBase64(data?.media)) {
-      return await this.waMonitor.waInstances[instanceName].mediaMessage(data, file);
+      return await this.getInstance(instanceName).mediaMessage(data, file);
     }
     throw new BadRequestException('Owned media must be a url or base64');
   }
 
   public async sendPtv({ instanceName }: InstanceDto, data: SendPtvDto, file?: any) {
     if (file || isURL(data?.video) || isBase64(data?.video)) {
-      return await this.waMonitor.waInstances[instanceName].ptvMessage(data, file);
+      return await this.getInstance(instanceName).ptvMessage(data, file);
     }
     throw new BadRequestException('Owned media must be a url or base64');
   }
 
   public async sendSticker({ instanceName }: InstanceDto, data: SendStickerDto, file?: any) {
     if (file || isURL(data.sticker) || isBase64(data.sticker)) {
-      return await this.waMonitor.waInstances[instanceName].mediaSticker(data, file);
+      return await this.getInstance(instanceName).mediaSticker(data, file);
     }
     throw new BadRequestException('Owned media must be a url or base64');
   }
 
   public async sendWhatsAppAudio({ instanceName }: InstanceDto, data: SendAudioDto, file?: any) {
     if (file?.buffer || isURL(data.audio) || isBase64(data.audio)) {
-      // Si file existe y tiene buffer, o si es una URL o Base64, continúa
-      return await this.waMonitor.waInstances[instanceName].audioWhatsapp(data, file);
+      return await this.getInstance(instanceName).audioWhatsapp(data, file);
     } else {
       console.error('El archivo no tiene buffer o el audio no es una URL o Base64 válida');
       throw new BadRequestException('Owned media must be a url, base64, or valid file with buffer');
     }
   }
 
   public async sendButtons({ instanceName }: InstanceDto, data: SendButtonsDto) {
-    return await this.waMonitor.waInstances[instanceName].buttonMessage(data);
+    return await this.getInstance(instanceName).buttonMessage(data);
   }
 
   public async sendLocation({ instanceName }: InstanceDto, data: SendLocationDto) {
-    return await this.waMonitor.waInstances[instanceName].locationMessage(data);
+    return await this.getInstance(instanceName).locationMessage(data);
   }
 
   public async sendList({ instanceName }: InstanceDto, data: SendListDto) {
-    return await this.waMonitor.waInstances[instanceName].listMessage(data);
+    return await this.getInstance(instanceName).listMessage(data);
   }
 
   public async sendContact({ instanceName }: InstanceDto, data: SendContactDto) {
-    return await this.waMonitor.waInstances[instanceName].contactMessage(data);
+    return await this.getInstance(instanceName).contactMessage(data);
   }
 
   public async sendReaction({ instanceName }: InstanceDto, data: SendReactionDto) {
     if (!isEmoji(data.reaction)) {
       throw new BadRequestException('Reaction must be a single emoji or empty string');
     }
-    return await this.waMonitor.waInstances[instanceName].reactionMessage(data);
+    return await this.getInstance(instanceName).reactionMessage(data);
   }
 
   public async sendPoll({ instanceName }: InstanceDto, data: SendPollDto) {
-    return await this.waMonitor.waInstances[instanceName].pollMessage(data);
+    return await this.getInstance(instanceName).pollMessage(data);
   }
 
   public async sendStatus({ instanceName }: InstanceDto, data: SendStatusDto, file?: any) {
-    return await this.waMonitor.waInstances[instanceName].statusMessage(data, file);
+    return await this.getInstance(instanceName).statusMessage(data, file);
   }
 }