[Bug] TemporalWorkerDeployment creates Deployment with invalid name when image tag contains uppercase characters

[berserker5000]

When using TemporalWorkerDeployment with an image tag that contains uppercase characters, the controller creates a Kubernetes Deployment with an invalid name that violates RFC 1123 subdomain naming rules, causing the deployment to fail.
Environment:

temporal-worker-controller version: 0.73.1
Kubernetes version: 1.34
Temporal Cloud

Steps to Reproduce:

1. Create a TemporalWorkerDeployment resource with an image tag containing uppercase characters:

apiVersion: temporal.io/v1alpha1
kind: TemporalWorkerDeployment
metadata:
  name: name
  namespace: my-namespace
spec:
  replicas: 1
  template:
    spec:
      containers:
      - name: name
        image: <image>:<CamelCaseTag> (example nginx:branch-NGX-123)

2. Apply the resource to the cluster
3. Observe the created Deployment name

Expected Behavior:
The controller should accept any tag name.
Root Cause Analysis:
The controller appears to derive the Deployment name from a combination of the TemporalWorkerDeployment name and the image tag (or a hash thereof). When the image tag contains uppercase characters (common in CI/CD pipelines using branch names like branch-PROJ-12345-feature-name), the resulting Deployment name violates Kubernetes naming conventions.

[carlydf]

Thanks for reporting this! Should be a quick fix. We clean the build id string to match DNS requirements, but missed that Deployment names have the lowercase requirement too.