feat: enhance compatibility and static analysis for testing

- Added `testing/src` to `psalm.xml` for better coverage.
- Unified OS constants using `OperatingSystem` across mappings.
- Improved handling of environment variables and type safety in `SystemInfo` and `Environment`.
- Refactored `RoadRunnerActivityInvocationCache` and `WorkerMock` for cleaner interfaces.
- Adjusted `Downloader` to use a working directory for asset management.

Author: xepozz

psalm-baseline.xml

@@ -1146,9 +1146,6 @@
       <code><![CDATA[$cacheName]]></code>
       <code><![CDATA[$host]]></code>
     </ArgumentTypeCoercion>
-    <MissingParamType>
-      <code><![CDATA[$value]]></code>
-    </MissingParamType>
     <PossiblyUndefinedStringArrayOffset>
       <code><![CDATA[$request->getOptions()['name']]]></code>
     </PossiblyUndefinedStringArrayOffset>
@@ -1350,9 +1347,6 @@
     <PossiblyUndefinedStringArrayOffset>
       <code><![CDATA[$headers[self::HEADER_TASK_QUEUE]]]></code>
     </PossiblyUndefinedStringArrayOffset>
-    <PropertyNotSetInConstructor>
-      <code><![CDATA[$codec]]></code>
-    </PropertyNotSetInConstructor>
     <UndefinedInterfaceMethod>
       <code><![CDATA[dispatch]]></code>
       <code><![CDATA[dispatch]]></code>
@@ -1371,4 +1365,25 @@
       <code><![CDATA[getUpdateContext]]></code>
     </UndefinedInterfaceMethod>
   </file>
+  <file src="testing/src/Downloader.php">
+    <PossiblyUndefinedStringArrayOffset>
+      <code><![CDATA[$asset['browser_download_url']]]></code>
+      <code><![CDATA[$response->toArray()['assets']]]></code>
+    </PossiblyUndefinedStringArrayOffset>
+  </file>
+  <file src="testing/src/Replay/WorkflowReplayer.php">
+    <UndefinedMethod>
+      <code><![CDATA[getWorkflowType]]></code>
+    </UndefinedMethod>
+  </file>
+  <file src="testing/src/TestService.php">
+    <UndefinedClass>
+      <code><![CDATA[ChannelCredentials]]></code>
+    </UndefinedClass>
+  </file>
+  <file src="testing/src/WorkerMock.php">
+    <DeprecatedMethod>
+      <code><![CDATA[registerActivityImplementations]]></code>
+    </DeprecatedMethod>
+  </file>
 </files>

psalm.xml

@@ -17,6 +17,7 @@
 >
     <projectFiles>
         <directory name="src" />
+        <directory name="testing/src" />
         <ignoreFiles>
             <directory name="vendor" />
         </ignoreFiles>

src/Worker/ActivityInvocationCache/RoadRunnerActivityInvocationCache.php

@@ -41,7 +41,7 @@ public function clear(): void
         $this->cache->clear();
     }
 
-    public function saveCompletion(string $activityMethodName, $value): void
+    public function saveCompletion(string $activityMethodName, mixed $value): void
     {
         $this->cache->set($activityMethodName, ActivityInvocationResult::fromValue($value, $this->dataConverter));
     }

src/WorkerFactory.php

@@ -111,6 +111,7 @@ public function __construct(
         ?ServiceCredentials $credentials = null,
     ) {
         $this->converter = $dataConverter;
+        $this->codec = $this->createCodec();
         $this->boot($credentials ?? ServiceCredentials::create());
     }
 
@@ -190,7 +191,6 @@ public function getEnvironment(): EnvironmentInterface
     public function run(?HostConnectionInterface $host = null): int
     {
         $host ??= RoadRunner::create();
-        $this->codec = $this->createCodec();
 
         while ($msg = $host->waitBatch()) {
             try {

testing/src/ActivityMocker.php

@@ -21,11 +21,17 @@ public function clear(): void
         $this->cache->clear();
     }
 
-    public function expectCompletion(string $activityMethodName, $value): void
+    /**
+     * @param non-empty-string $activityMethodName
+     */
+    public function expectCompletion(string $activityMethodName, mixed $value): void
     {
         $this->cache->saveCompletion($activityMethodName, $value);
     }
 
+    /**
+     * @param non-empty-string $activityMethodName
+     */
     public function expectFailure(string $activityMethodName, \Throwable $error): void
     {
         $this->cache->saveFailure($activityMethodName, $error);

testing/src/Command.php

@@ -12,14 +12,15 @@ final class Command
     /** @var non-empty-string|null Temporal Address */
     public ?string $address = null;
 
-    /** @var non-empty-string|null */
     public ?string $tlsKey = null;
 
-    /** @var non-empty-string|null */
     public ?string $tlsCert = null;
 
-    private array $xdebug;
+    private array $xdebug = [];
 
+    /**
+     * @param non-empty-string|null $address
+     */
     public function __construct(
         ?string $address = null,
     ) {
@@ -28,9 +29,11 @@ public function __construct(
 
     public static function fromEnv(): self
     {
-        $self = new self(\getenv('TEMPORAL_ADDRESS') ?: '127.0.0.1:7233');
+        $address = \getenv('TEMPORAL_ADDRESS');
+        $self = new self((is_string($address) && $address !== '') ? $address : '127.0.0.1:7233');
 
-        $self->namespace = \getenv('TEMPORAL_NAMESPACE') ?: 'default';
+        $namespace = \getenv('TEMPORAL_NAMESPACE');
+        $self->namespace = (is_string($namespace) && $namespace !== '') ? $namespace : 'default';
         $self->xdebug = [
             'xdebug.mode' => \ini_get('xdebug.mode'),
             'xdebug.start_with_request' => \ini_get('xdebug.start_with_request'),
@@ -70,13 +73,17 @@ public static function fromCommandLine(array $argv): self
                     break;
             }
         }
+        if (empty($address)) {
+            throw new \InvalidArgumentException('Address cannot be empty');
+        }
+        if (empty($namespace)) {
+            throw new \InvalidArgumentException('Namespace cannot be empty');
+        }
 
         $self = new self($address);
-
         $self->namespace = $namespace;
         $self->tlsCert = $tlsCert;
         $self->tlsKey = $tlsKey;
-
         return $self;
     }
 

testing/src/Downloader.php

@@ -15,6 +15,7 @@ final class Downloader
     private Filesystem $filesystem;
     private HttpClientInterface $httpClient;
     private string $javaSdkUrl;
+    private string $workingDir;
 
     public function __construct(
         Filesystem $filesystem,
@@ -27,15 +28,23 @@ public function __construct(
             $javaSdkVersion === self::TAG_LATEST => self::TAG_LATEST,
             default => "tags/$javaSdkVersion",
         };
+
+        $workingDir = \getcwd();
+        if ($workingDir === false) {
+            throw new \RuntimeException('Failed to get current working directory.');
+        }
+
+        $this->workingDir = $workingDir;
     }
 
     public function download(SystemInfo $systemInfo): void
     {
         $asset = $this->getAsset($systemInfo);
+        /** @var string $assetUrl */
         $assetUrl = $asset['browser_download_url'];
         $pathToExtractedAsset = $this->downloadAsset($assetUrl);
 
-        $targetPath = \getcwd() . DIRECTORY_SEPARATOR . $systemInfo->temporalServerExecutable;
+        $targetPath = $this->workingDir . DIRECTORY_SEPARATOR . $systemInfo->temporalServerExecutable;
         $this->filesystem->copy($pathToExtractedAsset . DIRECTORY_SEPARATOR . $systemInfo->temporalServerExecutable, $targetPath);
         $this->filesystem->chmod($targetPath, 0755);
         $this->filesystem->remove($pathToExtractedAsset);
@@ -78,7 +87,7 @@ private function findAsset(array $assets, SystemInfo $systemInfo): array
     private function downloadAsset(string $assetUrl): string
     {
         $response = $this->httpClient->request('GET', $assetUrl);
-        $assetPath = \getcwd() . DIRECTORY_SEPARATOR . \basename($assetUrl);
+        $assetPath = $this->workingDir . DIRECTORY_SEPARATOR . \basename($assetUrl);
 
         if ($this->filesystem->exists($assetPath)) {
             $this->filesystem->remove($assetPath);
@@ -87,9 +96,9 @@ private function downloadAsset(string $assetUrl): string
         $this->filesystem->appendToFile($assetPath, $response->getContent());
 
         $phar = new \PharData($assetPath);
-        $extractedPath = \getcwd() . DIRECTORY_SEPARATOR . $phar->getFilename();
+        $extractedPath = $this->workingDir . DIRECTORY_SEPARATOR . $phar->getFilename();
         if (!$this->filesystem->exists($extractedPath)) {
-            $phar->extractTo(\getcwd());
+            $phar->extractTo($this->workingDir);
         }
         $this->filesystem->remove($phar->getPath());
 

testing/src/Environment.php

@@ -36,16 +36,19 @@ public function __construct(
 
     public static function create(?Command $command = null): self
     {
-        $token = \getenv('GITHUB_TOKEN');
-
         $systemInfo = SystemInfo::detect();
-        \is_string(\getenv('ROADRUNNER_BINARY')) and $systemInfo->rrExecutable = \getenv('ROADRUNNER_BINARY');
+        $roadRunnerBinary = \getenv('ROADRUNNER_BINARY');
+        if (\is_string($roadRunnerBinary)) {
+            $systemInfo->rrExecutable = $roadRunnerBinary;
+        }
+
+        $token = \getenv('GITHUB_TOKEN');
 
         return new self(
             new TestOutputStyle(new ArgvInput(), new ConsoleOutput()),
             new Downloader(new Filesystem(), HttpClient::create([
                 'headers' => [
-                    'authorization' => $token ? 'token ' . $token : null,
+                    'authorization' => \is_string($token) ? 'token ' . $token : null,
                 ],
             ])),
             $systemInfo,
@@ -122,7 +125,7 @@ public function startTemporalServer(
         $this->io->info('Running command: ' . $this->serializeProcess($this->temporalServerProcess));
         $this->temporalServerProcess->start();
 
-        $deadline = \microtime(true) + $commandTimeout;
+        $deadline = \microtime(true) + (float) $commandTimeout;
         while (!$temporalStarted && \microtime(true) < $deadline) {
             \usleep(10_000);
             $check = new Process([
@@ -162,7 +165,7 @@ public function startTemporalTestServer(int $commandTimeout = 10): void
             $this->io->info('Temporal test server downloaded.');
         }
 
-        $temporalPort = \parse_url($this->command->address, PHP_URL_PORT);
+        $temporalPort = \parse_url((string) $this->command->address, PHP_URL_PORT);
 
         $this->io->info('Starting Temporal test server... ');
         $this->temporalTestServerProcess = new Process(
@@ -192,7 +195,7 @@ public function startTemporalTestServer(int $commandTimeout = 10): void
     /**
      * @param array<string, mixed> $envs
      */
-    public function startRoadRunner(?string $rrCommand = null, int $commandTimeout = 10, array $envs = [], string $configFile = '.rr.yaml'): void
+    public function startRoadRunner(?array $rrCommand = null, int $commandTimeout = 10, array $envs = [], string $configFile = '.rr.yaml'): void
     {
         if (!$this->isTemporalRunning() && !$this->isTemporalTestRunning()) {
             $this->io->error([
@@ -202,7 +205,7 @@ public function startRoadRunner(?string $rrCommand = null, int $commandTimeout =
         }
 
         $this->roadRunnerProcess = new Process(
-            command: $rrCommand ? \explode(' ', $rrCommand) : [$this->systemInfo->rrExecutable, 'serve'],
+            command: $rrCommand ?? [$this->systemInfo->rrExecutable, 'serve'],
             env: $envs,
         );
         $this->roadRunnerProcess->setTimeout($commandTimeout);
@@ -213,7 +216,7 @@ public function startRoadRunner(?string $rrCommand = null, int $commandTimeout =
         $this->roadRunnerProcess->start();
 
         // wait for roadrunner to start
-        $deadline = \microtime(true) + $commandTimeout;
+        $deadline = \microtime(true) + (float) $commandTimeout;
         while (!$roadRunnerStarted && \microtime(true) < $deadline) {
             \usleep(10_000);
             $check = new Process([$this->systemInfo->rrExecutable, 'workers', '-c', $configFile]);
@@ -289,26 +292,38 @@ public function stopRoadRunner(): void
         }
     }
 
+    /**
+     * @psalm-assert Process $this->temporalServerProcess
+     */
     public function isTemporalRunning(): bool
     {
         return $this->temporalServerProcess?->isRunning() === true;
     }
 
+    /**
+     * @psalm-assert Process $this->roadRunnerProcess
+     */
     public function isRoadRunnerRunning(): bool
     {
         return $this->roadRunnerProcess?->isRunning() === true;
     }
 
+    /**
+     * @psalm-assert Process $this->temporalTestServerProcess
+     */
     public function isTemporalTestRunning(): bool
     {
         return $this->temporalTestServerProcess?->isRunning() === true;
     }
 
-    private function serializeProcess(?Process $temporalServerProcess): string|array
+    private function serializeProcess(?Process $process): string
     {
-        $reflection = new \ReflectionClass($temporalServerProcess);
+        if ($process === null) {
+            return 'process is not started';
+        }
+        $reflection = new \ReflectionClass($process);
         $reflectionProperty = $reflection->getProperty('commandline');
-        $commandLine = $reflectionProperty->getValue($temporalServerProcess);
+        $commandLine = $reflectionProperty->getValue($process);
         return \implode(' ', $commandLine);
     }
 }

testing/src/Replay/WorkflowReplayer.php

@@ -34,7 +34,8 @@ final class WorkflowReplayer
 
     public function __construct()
     {
-        $this->rpc = new RPC(Relay::create(Environment::fromGlobals()->getRPCAddress()), new ProtobufCodec());
+        $rpcAddress = Environment::fromGlobals()->getRPCAddress();
+        $this->rpc = new RPC(Relay::create(!empty($rpcAddress) ? $rpcAddress : 'tcp://127.0.0.1:6001'), new ProtobufCodec());
     }
 
     /**
@@ -44,7 +45,6 @@ public function __construct()
      */
     public function replayHistory(History $history): void
     {
-        /** @var HistoryEvent|null $firstEvent */
         $firstEvent = $history->getEvents()[0] ?? null;
         $workflowType = $firstEvent?->getWorkflowExecutionStartedEventAttributes()?->getWorkflowType()?->getName()
             ?? throw new \LogicException('History is empty or broken.');
@@ -110,7 +110,10 @@ public function replayFromJSON(
         $this->sendRequest('temporal.ReplayFromJSON', $request);
     }
 
-    private function sendRequest(string $command, Message $request): ReplayResponse
+    /**
+     * @param non-empty-string $command
+     */
+    private function sendRequest(string $command, Message $request): void
     {
         $wfType = (string) $request->getWorkflowType()?->getName();
         try {
@@ -132,7 +135,7 @@ private function sendRequest(string $command, Message $request): ReplayResponse
         \assert($status !== null);
 
         if ($status->getCode() === 0) {
-            return $message;
+            return;
         }
 
         throw match ($status->getCode()) {