Using `ld` etc in event bus leads to infinite loop

[brendt]

The debug helper itself emits an event, which leads to an infinite loop when using ld and other debug functions in code that's run by the event bus

[xHeaven]

Wouldn't a static $isDispatchingItemsDebuggedEvent guard solve this issue?

[brendt]

Probably, I haven't looked into the issue yet, I only know it crashed a job on stitcher.io :p

[xHeaven]

This should fix it 👀 Maybe you can come up with a more elegant solution if needed.

diff --git a/packages/debug/src/Debug.php b/packages/debug/src/Debug.php
index 9ba9757..186fa97 100644
--- a/packages/debug/src/Debug.php
+++ b/packages/debug/src/Debug.php
@@ -40,6 +40,8 @@ public static function resolve(): self
      */
     public function log(array $items, bool $writeToLog = true, bool $writeToOut = true): void
     {
+        static $isDispatchingItemsDebuggedEvent = false;
+
         $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
         $callPath = $trace[1]['file'] . ':' . $trace[1]['line'];
 
@@ -51,7 +53,17 @@ public function log(array $items, bool $writeToLog = true, bool $writeToOut = tr
             $this->writeToOut($items, $callPath);
         }
 
-        $this->eventBus?->dispatch(new ItemsDebugged($items));
+        if (! $this->eventBus || $isDispatchingItemsDebuggedEvent) {
+            return;
+        }
+
+        $isDispatchingItemsDebuggedEvent = true;
+
+        try {
+            $this->eventBus->dispatch(new ItemsDebugged($items));
+        } finally {
+            $isDispatchingItemsDebuggedEvent = false;
+        }
     }
 
     private function writeToLog(array $items, string $callPath): void

[brendt]

That's exactly what I had in mind. Feel free to PR :)