fix: Improves pull request filtering logic

Author: isaacsanders

check.go

@@ -5,6 +5,7 @@ import (
 	"path/filepath"
 	"regexp"
 	"sort"
+	"strconv"
 	"strings"
 
 	"github.com/shurcooL/githubv4"
@@ -44,8 +45,10 @@ Loop:
 			continue
 		}
 
-		// Filter out commits that are too old.
-		if !p.UpdatedDate().Time.After(request.Version.CommittedDate) {
+		// Filter out commits that are too old and don't have more approvals.
+		approvedReviewCount, err := strconv.Atoi(request.Version.ApprovedReviewCount)
+		if !(p.UpdatedDate().Time.After(request.Version.CommittedDate) ||
+			(err != nil && p.ApprovedReviewCount > approvedReviewCount)) {
 			continue
 		}
 

check_test.go

@@ -23,6 +23,13 @@ var (
 		createTestPR(10, "master", false, false, 0, nil, false, githubv4.PullRequestStateClosed),
 		createTestPR(11, "master", false, false, 0, nil, false, githubv4.PullRequestStateMerged),
 		createTestPR(12, "master", false, false, 0, nil, false, githubv4.PullRequestStateOpen),
+		createTestPR(13, "master", false, false, 0, nil, false, githubv4.PullRequestStateOpen),
+		createTestPR(13, "master", false, false, 1, nil, false, githubv4.PullRequestStateOpen),
+	}
+
+	testApprovalPullRequests = []*resource.PullRequest{
+		createTestPR(1, "master", false, false, 0, nil, false, githubv4.PullRequestStateOpen),
+		createTestPR(1, "master", false, false, 1, nil, false, githubv4.PullRequestStateOpen),
 	}
 )
 
@@ -262,6 +269,20 @@ func TestCheck(t *testing.T) {
 				resource.NewVersion(testPullRequests[10]),
 			},
 		},
+
+		{
+			description: "check returns versions with more approvals, even if time is the same",
+			source: resource.Source{
+				Repository:  "itsdalmo/test-repository",
+				AccessToken: "oauthtoken",
+			},
+			version:      resource.NewVersion(testApprovalPullRequests[0]),
+			pullRequests: testApprovalPullRequests,
+			files:        [][]string{},
+			expected: resource.CheckResponse{
+				resource.NewVersion(testApprovalPullRequests[1]),
+			},
+		},
 	}
 
 	for _, tc := range tests {