From 4cb79c9814b22c6c3cf5092fa7aa8830313ce625 Mon Sep 17 00:00:00 2001 From: Dan Hensby Date: Fri, 5 Jun 2026 17:10:59 +0100 Subject: [PATCH] ci: disable fail-fast on the windows test matrix MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The test-windows job did not set fail-fast, so GitHub Actions defaulted to fail-fast: true. A single transient failure — often during the multi-minute SQL Server setup phase — cancelled every other in-progress and queued sibling job in the windows matrix. Those cancelled jobs would otherwise have passed, and re-running forced the entire expensive setup to be redone for all combinations. The test-linux matrix intentionally keeps fail-fast enabled: those jobs bootstrap much faster, and because test-windows needs test-linux, a linux failure should stop the run before the slower windows matrix starts rather than wasting time on it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .github/workflows/nodejs.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 97b4fbcb..e4c0d969 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -113,6 +113,7 @@ jobs: env: MSSQL_PASSWORD: 'yourStrong(!)Password' strategy: + fail-fast: false matrix: os: [windows-2022, windows-2025] node: [18.x, 20.x, 22.x, 24.x]