Name bikeshed

[mhofman]

From #1:

Naming Bikeshed

Is concat the best name? Who knows!? Let's figure out the right name for the bikeshed. Other options could include join(...) given the possible semantic similarity to joining strings.. but that seems weird, especially given that %TypedArray% is itself an iterable and we may be having a join(...) API for Iterables in general.

New API or existing?

We could, at least theoretically, modify %TypedArray%.from to support this case by allowing source to be an iterable of %TypedArray% instead of an iterable of elements. That seems a bit problematic for several reasons. One, it's confusing. Two, it's not discoverable for user code and is likely more difficult to polyfill.

My concern with concat is that it's currently a prototype method on strings, which makes it have slightly different semantics.

One suggestion: fromChunks to avoid overloading from.

This might also help avoid conflicts with the Node.js concat if we want a slightly different arguments shape.

[ljharb]

If it's named concat, the API design is pretty fixed, including it being a prototype method.

I do think "concat" is the right name here, but it'd have to be named something else if its API doesn't match the array/string ones.

[jasnell]

Currently, it's a static %TypedArray%.concat and not %TypedArray%.prototype.concat ... but the naming concerns are certainly legitimate... For now I'll keep it as concat but we'll need to bikeshed a bit more.

[bakkot]

Iterator.concat shipped as a static method. But it takes varargs rather than an iterable (so following that pattern would leave no place to put the length argument). If you're attached to having an additional argument, probably best to find another name.

[jasnell]

Definitely want to keep the additional argument. Hmm.. ok. That's a bit unfortunate

Some options:

• `%TypedArray%.fromChunks(...)
• `%TypedArray%.fromList(...)
• `%TypedArray%.fromParts(...)
• `%TypedArray%.fromSegments(...)

I've no strong preference among these.

[jasnell]

Currently leaning towards %TypedArray%.fromList(...) ... planning to go with that unless someone throws something heavy at me.