Remove unneeded slice for nonTerminatingMachines

Author: thiyyakat

pkg/controller/machineset.go

@@ -336,21 +336,18 @@ func (c *controller) manageReplicas(ctx context.Context, allMachines []*v1alpha1
 	}
 
 	var (
-		nonTerminatingMachines               []*v1alpha1.Machine
+		numNonTerminatingMachines            int
 		machinesWithoutUpdateSuccessfulLabel []*v1alpha1.Machine
 	)
 	for _, m := range allMachines {
 		if m.Status.CurrentStatus.Phase != v1alpha1.MachineTerminating {
-			nonTerminatingMachines = append(nonTerminatingMachines, m)
-		}
-	}
-
-	for _, m := range nonTerminatingMachines {
-		if m.Labels[v1alpha1.LabelKeyNodeUpdateResult] != v1alpha1.LabelValueNodeUpdateSuccessful {
-			machinesWithoutUpdateSuccessfulLabel = append(machinesWithoutUpdateSuccessfulLabel, m)
+			numNonTerminatingMachines++
+			if m.Labels[v1alpha1.LabelKeyNodeUpdateResult] != v1alpha1.LabelValueNodeUpdateSuccessful {
+				machinesWithoutUpdateSuccessfulLabel = append(machinesWithoutUpdateSuccessfulLabel, m)
+			}
 		}
 	}
-	nonTerminatingMachinesDiff := len(nonTerminatingMachines) - int(machineSet.Spec.Replicas)
+	nonTerminatingMachinesDiff := numNonTerminatingMachines - int(machineSet.Spec.Replicas)
 	machinesWithoutUpdateSuccessfulLabelDiff := len(machinesWithoutUpdateSuccessfulLabel) - int(machineSet.Spec.Replicas)
 
 	// During in-place updates, ScaleUps are disabled in the oldMachineSet and