Implement Panther Lake power sequence

Author: jackpot51

src/app/main/power/intel.c

@@ -84,6 +84,11 @@
 #define HAVE_PD_EN 0
 #endif
 
+// Introduced with Panther Lake, disabled by default
+#ifndef HAVE_VCCST_EN
+#define HAVE_VCCST_EN 0
+#endif
+
 #ifndef HAVE_XLP_OUT
 #define HAVE_XLP_OUT 1
 #endif
@@ -138,12 +143,12 @@ enum PowerState calculate_power_state(void) {
 #if CONFIG_BUS_ESPI
     // Use eSPI virtual wires if available
 
-    if (vw_get(&VW_SLP_S4_N) != VWS_HIGH) {
+    if (vw_get_ignore_invalid(&VW_SLP_S4_N) != VWS_HIGH) {
         // S4 plane not powered
         return POWER_STATE_S5;
     }
 
-    if (vw_get(&VW_SLP_S3_N) != VWS_HIGH) {
+    if (vw_get_ignore_invalid(&VW_SLP_S3_N) != VWS_HIGH) {
         // S3 plane not powered
         return POWER_STATE_S3;
     }
@@ -201,6 +206,27 @@ void power_init(void) {
     update_power_state();
 }
 
+#if HAVE_VCCST_EN
+static void power_vccst_update(void) {
+    //TODO: verify against panther lake design guide
+    static bool last_vccst_en = false;
+    bool vccst_en = gpio_get(&VCCST_EN);
+    if (vccst_en != last_vccst_en) {
+        if (vccst_en) {
+            DEBUG("%02X: VCCST_EN asserted\n", main_cycle);
+
+            // Delay for power good
+            //TODO: determine ideal delay
+            delay_ms(200);
+        } else {
+            DEBUG("%02X: VCCST_EN de-asserted\n", main_cycle);
+        }
+        GPIO_SET_DEBUG(VCCST_EN_PG, vccst_en);
+        last_vccst_en = vccst_en;
+    }
+}
+#endif
+
 void power_on(void) {
     // Configure WLAN GPIOs before powering on
     wireless_power(true);
@@ -266,6 +292,10 @@ void power_on(void) {
             break;
         }
 
+#if HAVE_VCCST_EN
+        power_vccst_update();
+#endif
+
 #if CONFIG_BUS_ESPI
         // Check for VW changes
         espi_event();
@@ -524,6 +554,10 @@ void power_event(void) {
 #endif
 #endif // HAVE_SLP_SUS_N
 
+#if HAVE_VCCST_EN
+    power_vccst_update();
+#endif
+
 #if CONFIG_BUS_ESPI
     // ESPI systems must keep S5 planes powered unless VW_SUS_PWRDN_ACK is high
     if (vw_get(&VW_SUS_PWRDN_ACK) == VWS_HIGH)

src/board/system76/lemp14/gpio.c

@@ -20,12 +20,15 @@ struct Gpio __code LID_SW_N =       GPIO(B, 1);
 struct Gpio __code ME_WE =          GPIO(D, 7);
 struct Gpio __code PCH_PWROK_EC =   GPIO(F, 3);
 struct Gpio __code PD_EN =          GPIO(D, 0); // renamed to PD_POWER_EN
+struct Gpio __code PM_PWROK =       GPIO(H, 7); // renamed to EC_PWROK
 struct Gpio __code PWR_BTN_N =      GPIO(D, 5);
 struct Gpio __code PWR_SW_N =       GPIO(B, 3);
 struct Gpio __code SLP_S0_N =       GPIO(B, 5);
 struct Gpio __code SUSB_N_PCH =     GPIO(H, 0);
 struct Gpio __code SUSC_N_PCH =     GPIO(H, 1);
 struct Gpio __code VA_EC_EN =       GPIO(J, 4);
+struct Gpio __code VCCST_EN =       GPIO(D, 3);
+struct Gpio __code VCCST_EN_PG =    GPIO(H, 6);
 struct Gpio __code WLAN_PWR_EN =    GPIO(A, 3);
 struct Gpio __code XLP_OUT =        GPIO(B, 4);
 // uncrustify:on
@@ -90,7 +93,7 @@ static const struct GpioInit __code gpio_cfg_init[] = {
     { &GPCRD0, GPIO_OUT }, // PD_POWER_EN
     { &GPCRD1, GPIO_OUT }, // CCD_EN
     { &GPCRD2, GPIO_ALT }, // ESPI_RESET#
-    { &GPCRD3, GPIO_IN }, // SLP_A#
+    { &GPCRD3, GPIO_IN }, // VCCST_EN
     { &GPCRD4, GPIO_OUT }, // LED_PWR
     { &GPCRD5, GPIO_OUT }, // EC_PWR_BTN#
     { &GPCRD6, GPIO_ALT | GPIO_DOWN }, // CPU_FANSEN
@@ -129,8 +132,8 @@ static const struct GpioInit __code gpio_cfg_init[] = {
     { &GPCRH3, GPIO_OUT }, // 3G_EN
     { &GPCRH4, GPIO_OUT }, // 3G_PWR_EN
     { &GPCRH5, GPIO_IN }, // TBTA_VBUS_1_EN#
-    { &GPCRH6, GPIO_IN }, // Not connected
-    { &GPCRH7, GPIO_IN }, // Not connected
+    { &GPCRH6, GPIO_OUT }, // VCCST_EN_PG
+    { &GPCRH7, GPIO_OUT }, // EC_PWROK
 
     { &GPCRI0, GPIO_ALT }, // BAT_DET
     { &GPCRI1, GPIO_ALT }, // BAT_VOLT

src/board/system76/lemp14/include/board/gpio.h

@@ -30,7 +30,7 @@ extern struct Gpio __code ME_WE;
 extern struct Gpio __code PCH_PWROK_EC;
 #define HAVE_PD_EN 1
 extern struct Gpio __code PD_EN;
-#define HAVE_PM_PWROK 0
+extern struct Gpio __code PM_PWROK;
 extern struct Gpio __code PWR_BTN_N;
 extern struct Gpio __code PWR_SW_N;
 extern struct Gpio __code SLP_S0_N;
@@ -40,6 +40,9 @@ extern struct Gpio __code SUSC_N_PCH;
 #define HAVE_SUSWARN_N 0
 #define HAVE_SUS_PWR_ACK 0
 extern struct Gpio __code VA_EC_EN;
+#define HAVE_VCCST_EN 1
+extern struct Gpio __code VCCST_EN;
+extern struct Gpio __code VCCST_EN_PG;
 #define HAVE_WLAN_EN 0
 extern struct Gpio __code WLAN_PWR_EN;
 extern struct Gpio __code XLP_OUT;

src/ec/ite/espi.c

@@ -50,6 +50,16 @@ enum VirtualWireState vw_get(struct VirtualWire *const vw) __critical {
     }
 }
 
+// Panther Lake sets validity only when signals change
+enum VirtualWireState vw_get_ignore_invalid(struct VirtualWire *const vw) __critical {
+    uint8_t index = *vw->index;
+    if (index & vw->data_mask) {
+        return VWS_HIGH;
+    } else {
+        return VWS_LOW;
+    }
+}
+
 void vw_set(struct VirtualWire *const vw, enum VirtualWireState state) __critical {
     uint8_t index = *vw->index;
     switch (state) {

src/ec/ite/include/ec/espi.h

@@ -26,6 +26,7 @@ enum VirtualWireState {
 };
 
 enum VirtualWireState vw_get(struct VirtualWire *const vw) __critical;
+enum VirtualWireState vw_get_ignore_invalid(struct VirtualWire *const vw) __critical;
 
 void vw_set(struct VirtualWire *const vw, enum VirtualWireState state) __critical;