chore: upgrade to golangci-lint v2 (celestiaorg#4280)

Co-authored-by: quantix9 <quantix9@proton.me>

Author: Wondertan

.github/workflows/go-ci.yml

@@ -41,7 +41,7 @@ jobs:
           go-version: ${{ inputs.go-version }}
 
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6.5.0
+        uses: golangci/golangci-lint-action@v8.0.0
         with:
           args: --timeout 10m
           version: latest

.golangci.yml

@@ -1,82 +1,87 @@
+version: "2"
 run:
   timeout: 5m
-
 linters:
   enable:
+    - asciicheck
     - bidichk
     - bodyclose
-     # - depguard as of v1.54.2, the default config throws errors on our repo
+    - copyloopvar
     - dogsled
     - dupl
-    - errcheck
+    - dupword
     - errorlint
-    # - funlen
-    # - gochecknoglobals
-    # - gochecknoinits
-    - copyloopvar
     - gocheckcompilerdirectives
     - goconst
     - gocritic
-    # - gocyclo
-    # - godox
-    - gofmt
-    - gofumpt
-    - goimports
-    # - golint - deprecated since v1.41. revive will be used instead
-    - revive
     - gosec
-    - gosimple
-    - govet
-    - ineffassign
-    # - interfacer
     - lll
     - loggercheck
     - misspell
-    # - maligned
     - nakedret
     - nilerr
     - nilnil
     - nolintlint
     - prealloc
     - protogetter
-    # - scopelint - deprecated since v1.39. exportloopref will be used instead
+    - revive
     - staticcheck
-    - stylecheck
-    - typecheck
     - unconvert
-    # - unparam
-    - unused
-    # - whitespace
-    # - wsl
-    # - gocognit
     - wastedassign
     - whitespace
-    - nolintlint
-    - asciicheck
-    - dupword
-
+  settings:
+    dogsled:
+      max-blank-identifiers: 3
+    dupl:
+      threshold: 200
+    gosec:
+      excludes:
+        - G115
+    misspell:
+      locale: US
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - linters:
+          - gosec
+          - revive
+        path: _test\.go
+      - linters:
+          - lll
+        source: https://
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
 issues:
-  exclude-rules:
-    - path: _test\.go
-      linters:
-        - gosec
-        - revive
-    - linters:
-        - lll
-      source: "https://"
   max-same-issues: 50
-
-linters-settings:
-  gosec:
-    excludes:
-      - G115 # integer overflow conversion
-  dogsled:
-    max-blank-identifiers: 3
-  misspell:
-    locale: US
-  goimports:
-    local-prefixes: github.com/celestiaorg/celestia-node
-  dupl:
-    threshold: 200
-  gofumpt:
-    extra-rules: true
+formatters:
+  enable:
+    - gofmt
+    - gofumpt
+    - goimports
+    - golines
+  settings:
+    gofumpt:
+      extra-rules: true
+    goimports:
+      local-prefixes:
+        - github.com/celestiaorg/celestia-node
+    golines:
+      # Target maximum line length.
+      # Default: 100
+      max-len: 200
+      # Shorten single-line comments.
+      # Default: false
+      shorten-comments: true
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

blob/blob_test.go

@@ -78,7 +78,7 @@ func TestBlob(t *testing.T) {
 
 				newBlob := &Blob{}
 				require.NoError(t, newBlob.UnmarshalJSON(data))
-				require.True(t, bytes.Equal(blob[0].Blob.Data(), newBlob.Data()))
+				require.True(t, bytes.Equal(blob[0].Data(), newBlob.Data()))
 				require.True(t, bytes.Equal(blob[0].Commitment, newBlob.Commitment))
 			},
 		},

blob/service_test.go

@@ -149,7 +149,7 @@ func TestBlobService_Get(t *testing.T) {
 					require.NoError(t, err)
 					smpls, err := service.shareGetter.GetSamples(ctx, h, []shwap.SampleCoords{idx})
 					require.NoError(t, err)
-					require.True(t, bytes.Equal(smpls[0].Share.ToBytes(), resultShares[shareOffset].ToBytes()),
+					require.True(t, bytes.Equal(smpls[0].ToBytes(), resultShares[shareOffset].ToBytes()),
 						fmt.Sprintf("issue on %d attempt. ROW:%d, COL: %d, blobIndex:%d", i, row, col, blobs[i].index),
 					)
 					shareOffset += libshare.SparseSharesNeeded(uint32(len(blobs[i].Data())))

core/header_test.go

@@ -57,9 +57,9 @@ func TestMismatchedDataHash_ComputedRoot(t *testing.T) {
 
 func TestBadAppVersion(t *testing.T) {
 	header := headertest.RandExtendedHeader(t)
-	header.RawHeader.Version.App = appconsts.LatestVersion + 1
+	header.Version.App = appconsts.LatestVersion + 1
 
 	err := header.Validate()
 	assert.Contains(t, err.Error(), fmt.Sprintf("has version %d, this node supports up to version %d. Please "+
-		"upgrade to support new version", header.RawHeader.Version.App, appconsts.LatestVersion))
+		"upgrade to support new version", header.Version.App, appconsts.LatestVersion))
 }

das/coordinator_test.go

@@ -229,7 +229,7 @@ func TestCoordinator(t *testing.T) {
 		failedLastRun := map[uint64]int{4: 1, 8: 2, 15: 1, 16: 1, 23: 1, 42: 1, testParams.sampleFrom - 1: 1}
 
 		sampler := newMockSampler(testParams.sampleFrom, testParams.networkHead)
-		sampler.checkpoint.Failed = failedLastRun
+		sampler.Failed = failedLastRun
 
 		coordinator := newSamplingCoordinator(
 			testParams.dasParams,
@@ -380,7 +380,7 @@ func (m *mockSampler) sample(ctx context.Context, h *header.ExtendedHeader) erro
 	}
 
 	if height > m.NetworkHead || height < m.SampleFrom {
-		if _, ok := m.checkpoint.Failed[height]; !ok {
+		if _, ok := m.Failed[height]; !ok {
 			return fmt.Errorf("header: %v out of range: %v-%v", h, m.SampleFrom, m.NetworkHead)
 		}
 	}
@@ -421,8 +421,8 @@ func (m *mockSampler) finalState() checkpoint {
 func (m *mockSampler) discover(ctx context.Context, newHeight uint64, emit listenFn) {
 	m.lock.Lock()
 
-	if newHeight > m.checkpoint.NetworkHead {
-		m.checkpoint.NetworkHead = newHeight
+	if newHeight > m.NetworkHead {
+		m.NetworkHead = newHeight
 		if m.isFinished {
 			m.finishedCh = make(chan struct{})
 			m.isFinished = false

das/state.go

@@ -236,7 +236,7 @@ func (s *coordinatorState) unsafeStats() SamplingStats {
 			errMsg = wstats.err.Error()
 		}
 		workers = append(workers, WorkerStats{
-			JobType: wstats.job.jobType,
+			JobType: wstats.jobType,
 			Curr:    wstats.curr,
 			From:    wstats.from,
 			To:      wstats.to,

das/worker.go

@@ -148,7 +148,7 @@ func (w *worker) sample(ctx context.Context, timeout time.Duration, height uint6
 	logout := log.Debugw
 
 	// notify network about availability of new block data (note: only full nodes can notify)
-	if w.state.job.jobType == recentJob {
+	if w.state.jobType == recentJob {
 		err = w.broadcast(ctx, shrexsub.Notification{
 			DataHash: h.DataHash.Bytes(),
 			Height:   h.Height(),

header/header.go

@@ -99,7 +99,7 @@ func (eh *ExtendedHeader) Hash() libhead.Hash {
 
 // LastHeader returns the Hash of the last wrapped RawHeader.
 func (eh *ExtendedHeader) LastHeader() libhead.Hash {
-	return libhead.Hash(eh.RawHeader.LastBlockID.Hash)
+	return libhead.Hash(eh.LastBlockID.Hash)
 }
 
 // Equals returns whether the hash and height of the given header match.
@@ -109,15 +109,15 @@ func (eh *ExtendedHeader) Equals(header *ExtendedHeader) bool {
 
 // Validate performs *basic* validation to check for missed/incorrect fields.
 func (eh *ExtendedHeader) Validate() error {
-	err := eh.RawHeader.ValidateBasic()
+	err := eh.ValidateBasic()
 	if err != nil {
 		return fmt.Errorf("ValidateBasic error on RawHeader at height %d: %w", eh.Height(), err)
 	}
 
-	if eh.RawHeader.Version.App == 0 || eh.RawHeader.Version.App > appconsts.LatestVersion {
+	if eh.Version.App == 0 || eh.Version.App > appconsts.LatestVersion {
 		return fmt.Errorf("header received at height %d has version %d, this node supports up "+
 			"to version %d. Please upgrade to support new version. Note, 0 is not a valid version",
-			eh.RawHeader.Height, eh.RawHeader.Version.App, appconsts.LatestVersion)
+			eh.RawHeader.Height, eh.Version.App, appconsts.LatestVersion)
 	}
 
 	err = eh.Commit.ValidateBasic()

header/headertest/fraud/testing.go

@@ -93,6 +93,6 @@ func CreateFraudExtHeader(
 	dah, err := da.NewDataAvailabilityHeader(square)
 	require.NoError(t, err)
 	eh.DAH = &dah
-	eh.RawHeader.DataHash = dah.Hash()
+	eh.DataHash = dah.Hash()
 	return eh
 }