Skip to content

Commit da8ea1a

Browse files
committed
[SymForce-External] Bump pybind
Bump pybind Fixes #425 Our previous version of pybind didn't support py3.11. pybind 2.13.6 supports all versions of python that we support. There isn't much downside to downloading an additional copy of pybind if you have an older one installed that supports your version of python. If we wanted to we could write some table of minimum required versions based on SYMFORCE_PYTHON's version Topic: sf-pybind Relative: fix-wheels Closes #426 GitOrigin-RevId: 8dcd3ecad8b89835dec3431e9d611262fec2a277
1 parent 9c6d4ad commit da8ea1a

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

dev_requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ ptyprocess==0.7.0
225225
# via pexpect
226226
pure-eval==0.2.2
227227
# via stack-data
228-
pybind11-stubgen==2.5.1
228+
pybind11-stubgen==2.5.3
229229
# via symforce (setup.py)
230230
pygments==2.18.0
231231
# via

setup.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,8 @@ def fixed_readme() -> str:
401401
"numba",
402402
# 6.13 fixes pip >=23.1 support
403403
"pip-tools>=6.13",
404-
"pybind11-stubgen>=1.0",
404+
# For https://github.com/sizmailov/pybind11-stubgen/pull/243
405+
"pybind11-stubgen>=2.5.3",
405406
# 0.7.2 introduces this bug: https://github.com/astral-sh/ruff/pull/15090
406407
"ruff==0.7.1",
407408
"types-jinja2",

symforce/pybind/CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,16 @@
99

1010
include(FetchContent)
1111

12-
find_package(pybind11 2.9.2 QUIET)
12+
find_package(pybind11 2.13.6 QUIET)
1313
if (NOT pybind11_FOUND)
1414
message(STATUS "pybind11 not found, adding with FetchContent")
1515
# NOTE(brad): Set PYTHON_EXECUTABLE to ensure pybind11 uses the same
1616
# python as the rest of symforce.
1717
set(PYTHON_EXECUTABLE ${SYMFORCE_PYTHON})
1818
FetchContent_Declare(
1919
pybind11
20-
URL https://github.com/pybind/pybind11/archive/v2.9.2.zip
21-
URL_HASH SHA256=d1646e6f70d8a3acb2ddd85ce1ed543b5dd579c68b8fb8e9638282af20edead8
20+
URL https://github.com/pybind/pybind11/archive/v2.13.6.zip
21+
URL_HASH SHA256=d0a116e91f64a4a2d8fb7590c34242df92258a61ec644b79127951e821b47be6
2222
)
2323
FetchContent_MakeAvailable(pybind11)
2424
else()

0 commit comments

Comments
 (0)