ci: add golangci-lint

and resorb tech debt

Author: tucksaun

.github/workflows/test.yaml

@@ -5,6 +5,14 @@ on:
     push:
 
 jobs:
+  lint:
+    name: Lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v8
+
   test:
     runs-on: ubuntu-latest
     strategy:
@@ -20,7 +28,7 @@ jobs:
         - '1.24'
     name: Go ${{ matrix.go }} test
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
       - name: Setup go

.golangci.yml

@@ -0,0 +1,30 @@
+version: "2"
+
+run:
+  issues-exit-code: 1
+
+formatters:
+  enable:
+    - gofmt
+    - gci
+
+linters:
+  enable:
+    - wrapcheck
+  settings:
+    wrapcheck:
+      ignore-package-globs:
+        # We already make sure your own packages wrap errors properly
+        - github.com/symfony-cli/*
+    errcheck:
+        exclude-functions:
+          - github.com/symfony-cli/terminal.Printf
+          - github.com/symfony-cli/terminal.Println
+          - github.com/symfony-cli/terminal.Printfln
+          - github.com/symfony-cli/terminal.Eprintf
+          - github.com/symfony-cli/terminal.Eprintln
+          - github.com/symfony-cli/terminal.Eprintfln
+          - github.com/symfony-cli/terminal.Eprint
+          - fmt.Fprintln
+          - fmt.Fprintf
+          - fmt.Fprint

cert.go

@@ -144,7 +144,7 @@ func (ca *CA) Install(force bool) error {
 			return err
 		}
 		f, _ := os.OpenFile(ca.trustedpath, os.O_RDONLY|os.O_CREATE, 0644)
-		f.Close()
+		_ = f.Close()
 		terminal.Println("The local CA is now installed in the system trust store!")
 	}
 	if hasNSS() && (force || !ca.checkNSS()) {
@@ -168,7 +168,9 @@ func (ca *CA) Uninstall() error {
 	hasCertutil := certutilPath() != ""
 	if hasNSS() {
 		if hasCertutil {
-			ca.uninstallNSS()
+			if err := ca.uninstallNSS(); err != nil {
+				terminal.Printf("<warning>WARNING</> an error happened during CA uninstallation from %s: %s!\n", NSSBrowsers, err)
+			}
 		} else if CertutilInstallHelp != "" {
 			terminal.Printf("<warning>WARNING</> \"certutil\" is not available, so the CA can't be automatically uninstalled from %s (if it was ever installed)!\n", NSSBrowsers)
 			terminal.Printf("You can install \"certutil\" with \"%s\" and re-run the command\n", CertutilInstallHelp)
@@ -204,7 +206,9 @@ func Cert(filename string) (tls.Certificate, error) {
 		if err != nil {
 			return tls.Certificate{}, errors.WithStack(err)
 		}
-		defer ioutil.WriteFile(filename, pfxData, 0644)
+		if err := errors.WithStack(ioutil.WriteFile(filename, pfxData, 0644)); err != nil {
+			return tls.Certificate{}, err
+		}
 
 		certs := [][]byte{domainCert.Raw}
 		for _, c := range caCerts {

truststore_darwin.go

@@ -62,7 +62,10 @@ func (ca *CA) installPlatform() error {
 		return errors.Wrap(err, "failed to create temp file")
 	}
 
-	defer os.Remove(plistFile.Name())
+	defer func(name string) {
+		// a failure during removal of this file is not important
+		_ = os.Remove(name)
+	}(plistFile.Name())
 
 	cmd = commandWithSudo("security", "trust-settings-export", "-d", plistFile.Name())
 	if out, err := cmd.CombinedOutput(); err != nil {

truststore_nss.go

@@ -102,9 +102,9 @@ func (ca *CA) installNSS() error {
 	return nil
 }
 
-func (ca *CA) uninstallNSS() {
+func (ca *CA) uninstallNSS() error {
 	certutilPath := certutilPath()
-	ca.forEachNSSProfile(func(profile string) error {
+	_, err := ca.forEachNSSProfile(func(profile string) error {
 		err := exec.Command(certutilPath, "-V", "-d", profile, "-u", "L", "-n", ca.caUniqueName()).Run()
 		if err != nil {
 			return nil
@@ -115,6 +115,8 @@ func (ca *CA) uninstallNSS() {
 		}
 		return nil
 	})
+
+	return err
 }
 
 func (ca *CA) forEachNSSProfile(f func(profile string) error) (int, error) {
@@ -156,5 +158,5 @@ func execCertutil(cmd *exec.Cmd) ([]byte, error) {
 		cmd.Args = append(cmd.Args, origArgs...)
 		out, err = cmd.CombinedOutput()
 	}
-	return out, err
+	return out, errors.WithStack(err)
 }